Avoid introducing go-vet noise #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ack, sorry tests fail. will fix-- second |
Currently, go-logging introduces go-vet noise into client codebases. - introduces `-f` variants - changes old, non `-f` variants to use fmt.Sprint, as the `(*Logger) Panic` and `(*Logger) Fatal` functions do. - Adds a few comments that help logger.go pass golint - Fixes op#29
|
|
jbenet
added a commit
to ipfs/kubo
that referenced
this pull request
Oct 25, 2014
until op/go-logging#30 is merged
jbenet
added a commit
to ipfs/kubo
that referenced
this pull request
Oct 25, 2014
until op/go-logging#30 is merged
|
I can't merge this change as it would break backwards compatibility. I believe the API is sane though. Would be great if there were a generic log interface somewhere following this API, with an implementation for this and many other logging libraries. |
|
If you won't merge, why is this still open? |
|
I did listen to the community and merged #12 which added this functionality. Thanks. |
whyrusleeping
pushed a commit
to ipfs/go-unixfs
that referenced
this pull request
Jul 30, 2018
until op/go-logging#30 is merged
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 25, 2023
until op/go-logging#30 is merged This commit was moved from ipfs/go-unixfs@8e3a210
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29