Fix mediadb str issues #44
Conversation
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
- Coverage 47.27% 47.02% -0.25%
==========================================
Files 50 52 +2
Lines 10826 11408 +582
==========================================
+ Hits 5118 5365 +247
- Misses 5708 6043 +335
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
@opacam Any thoughts? I've just hit these again |
There was a problem hiding this comment.
LGTM!! 😄 , So many thanks and my apologies for not reviewing this before...
Note: I will leave this approved without merging for a few days, just in case that you want to address the comments. Otherwise don't worry, I'll do it after the merging. Thanks again!!!
| album: bytes = tags.get('album', b'') | ||
| artist: bytes = tags.get('artist', b'') | ||
| title: bytes = tags.get('title', b'') | ||
| track: int = tags.get('track', 0) |
pyproject.toml
Outdated
| twisted = ">=20.3.0, <22.1.0" # 22.1.0 removed HTTPPageGetter as it's now deprecated | ||
| "zope.interface" = "*" | ||
|
|
||
| # dev-dependencies | ||
| flake8 = {optional = true, version = "*"} | ||
| flake8 = {optional = true, version = ">=4"} # Because of https://github.com/PyCQA/flake8/issues/1564 |
|
🚀 Merged |
There's an issue with the use of
strin mediadb, and a lack of tests for it meant it didn't turn up, so I've fixed that.Needs #58 merging first for build fixes