Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize @@__isReady #115

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Initialize @@__isReady #115

merged 1 commit into from
Oct 11, 2021

Conversation

hmdne
Copy link
Member

@hmdne hmdne commented Oct 7, 2021

Compatibility with Opal v1.2.0. Should fix opal/opal#2325

Compatibility with Opal v1.2.0. Should fix opal/opal#2325
@LarryNorth
Copy link

I need some guidance. I'm new to the Ruby ecosystem, so I naively applied the patch using this in the Gemfile:
gem 'opal-jquery', git: 'https://github.com/hmdne/opal-jquery.git'

After which bundle info opal-jquery shows (the Path looks suspcious):

It didn't work. This runtime error occurred:
/usr/local/lib/ruby/3.0.0/rubygems/dependency.rb:311:in to_specs': Could not find 'opal-jquery' (>= 0) among 96 total gem(s) (Gem::MissingSpecError) Checked in 'GEM_PATH=/home/ruby/.local/share/gem/ruby/3.0.0:/usr/local/lib/ruby/gems/3.0.0:/usr/local/bundle' , execute gem envfor more information from /usr/local/lib/ruby/3.0.0/rubygems/dependency.rb:323:into_spec'
from /usr/local/lib/ruby/3.0.0/rubygems/specification.rb:985:in find_by_name' from /usr/local/bundle/gems/opal-1.0.5/lib/opal/paths.rb:49:in require_paths_for_gem'
from /usr/local/bundle/gems/opal-1.0.5/lib/opal/paths.rb:41:in use_gem' from /opt/app/init_opal.rb:7:in init'
from /opt/app/init_opal.rb:20:in <top (required)>' from <internal:/usr/local/lib/ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:85:in require'
from internal:/usr/local/lib/ruby/3.0.0/rubygems/core_ext/kernel_require.rb:85:in require' from /opt/app/config.ru:2:in block in

'
from /usr/local/bundle/gems/rack-2.2.3/lib/rack/builder.rb:116:in eval' from /usr/local/bundle/gems/rack-2.2.3/lib/rack/builder.rb:116:in new_from_string'
from /usr/local/bundle/gems/rack-2.2.3/lib/rack/builder.rb:105:in load_file' from /usr/local/bundle/gems/rack-2.2.3/lib/rack/builder.rb:66:in parse_file'
from /usr/local/bundle/gems/rack-2.2.3/lib/rack/server.rb:349:in build_app_and_options_from_config' from /usr/local/bundle/gems/rack-2.2.3/lib/rack/server.rb:249:in app'
from /usr/local/bundle/gems/rack-2.2.3/lib/rack/server.rb:422:in wrapped_app' from /usr/local/bundle/gems/rack-2.2.3/lib/rack/server.rb:312:in block in start'
from /usr/local/bundle/gems/rack-2.2.3/lib/rack/server.rb:379:in handle_profiling' from /usr/local/bundle/gems/rack-2.2.3/lib/rack/server.rb:311:in start'
from /usr/local/bundle/gems/rack-2.2.3/lib/rack/server.rb:168:in start' from /usr/local/bundle/gems/rack-2.2.3/bin/rackup:5:in <top (required)>'
from /usr/local/bundle/bin/rackup:23:in load' from /usr/local/bundle/bin/rackup:23:in '

@hmdne
Copy link
Member Author

hmdne commented Oct 8, 2021

No problem, this is the correct line:

gem 'opal-jquery', github: 'hmdne/opal-jquery', ref: 'patch-2'

Then, you will need to prefix your application execution with bundle exec, eg. bundle exec rackup

@LarryNorth
Copy link

LarryNorth commented Oct 8, 2021 via email

@elia elia merged commit 91ead7c into opal:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Different cvars semantics break opal-jquery between Opal 1.0.5 and 1.2.0
3 participants