Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to header tests #15

Closed
opalmer opened this issue Jul 29, 2015 · 0 comments · Fixed by #25
Closed

Improvements to header tests #15

opalmer opened this issue Jul 29, 2015 · 0 comments · Fixed by #25

Comments

@opalmer
Copy link
Owner

opalmer commented Jul 29, 2015

Right now the header tests, as implemented in #14, are kind of basic. Ideally we need to be sure of a couple of things:

  • Anything being defined in a header file must end up on the built library object. The tests already cover this but using regular expressions or string manipulation to discover the exported entries is flaky. It would be better if we parsed the syntax instead in the tests.
  • Anything that used to be defined in a header file remains defined (ie a definition can't be removed by accident). Although this library still under development it's good policy to get into this habit now so compatibility is not broken by accident. A small tool to parse/dump a reference object for use in the tests would probably be sufficient.
@opalmer opalmer added this to the 0.1.0 milestone Jul 29, 2015
@opalmer opalmer closed this as completed Nov 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant