Improve Error Handling #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a few reasons for these change:
* The things prefixed with api_* didn't
really describe if the thing being referenced
was a Windows API or our own.
* Attributes like errno and code are typical
on other kinds of errors so people will likely
expect these.
* There was not any documentation for the input
arguments before.
* __repr__() should show the complete error.
Current coverage is
|
There have been a couple of refactors since the last release with API changes. These will be much more limited in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves on the error handling by:
WindowsAPIErroris more consistent and better documentederror_checkand ensuring it's easier to tell what the original error was.This came about while working on #57 where internal errors were sometimes obscuring the underlying API errors. There are probably further improvements to be made here but this should simplify future work.