Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional File Functions #61

Merged
merged 35 commits into from
Mar 6, 2016
Merged

Additional File Functions #61

merged 35 commits into from
Mar 6, 2016

Conversation

opalmer
Copy link
Owner

@opalmer opalmer commented Feb 10, 2016

This PR:

  • Adds CreateFile() - Can be used by twisted.python.lockfile to create files which can be read but not written to.
    • Add test to check for proper behavior of CREATE_ALWAYS and ERROR_ALREADY_EXISTS
    • Add test for the new LP_SECURITY_ATTRIBUTES structure.
  • Adds LockFileEx() - So a file can be locked while operations are being performed.
    • Tests for LockFileEx()
  • Adds UnlockFileEx() - Reverses LockFileEx()
    • Tests for UnlockFileEx()

@codecov-io
Copy link

Current coverage is 95.70%

Merging #61 into master will decrease coverage by -0.64% as of 9ee9355

Powered by Codecov. Updated on successful CI builds.

@opalmer opalmer self-assigned this Feb 10, 2016
@opalmer opalmer added this to the 0.2.0 milestone Feb 10, 2016
opalmer added 21 commits February 10, 2016 23:48
@opalmer
fixing handling of WindowsAPIError for dwCreationDisposition
541825f
@opalmer
initial tests for CreateFile()
20bd6a4
@opalmer
remove unused code
a6d8efe
@opalmer
adding ERROR_PATH_NOT_FOUND
38dae14
@opalmer
adding a couple more tests for error handling
589e7bf
@opalmer
don't override 'file' function on 2.7
40d7675
@opalmer
adding missing test for nullable state of Enums.OVERLAPPED
c8515cd
@opalmer
it's LPSECURITY_ATTRIBUTES (no space)
6dfa309
@opalmer
use SECURITY_ATTRIBUTES as the enum name instead
883a444
@opalmer
initial tests
629ad89
@opalmer
making regex broader so (otherwise it limits how the struct could be …
b9bfbaa 
…built)
@opalmer
tests for LPSECURITY_ATTRIBUTES
bbbfbc2
@opalmer
test fix
9f5049a
@opalmer
adding LockFileEx() to functions
a0e07df
@opalmer
adding constants for LockFileEx
e345ac9
@opalmer
initial Python implementation of LockFileEx
f6039cf
@opalmer
Merge branch 'master' of github.com:opalmer/pywincffi into file_funcs
5cf1198
@opalmer
adding LockFileEx to imports
29b70f6
@opalmer
placeholder test
a324643
@opalmer
merging origin/master
8c9eccd
@opalmer
fix lpOverlapped variable name, make it a keyword too
3c768b9
opalmer added a commit that referenced this pull request Mar 6, 2016
@opalmer
Merge pull request #61 from opalmer/file_funcs
e578643 
Additional File Functions
@opalmer opalmer merged commit e578643 into master Mar 6, 2016
@opalmer opalmer deleted the file_funcs branch March 6, 2016 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@opalmer opalmer

Labels
enhancement lib: kernel32
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@opalmer @codecov-io