Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CreateProcess #98

Merged
merged 44 commits into from
Jul 16, 2016
Merged

Implement CreateProcess #98

merged 44 commits into from
Jul 16, 2016

Conversation

opalmer
Copy link
Owner

@opalmer opalmer commented Jun 12, 2016 •
edited
Loading

This PR implements the CreateProcess function which is required by #69.

TODO

  • Return a namedtuple from CreateProcess
  • Add properties for PROCESS_INFORMATION structure
  • Add new tests for PROCESS_INFORMATION structure
  • Add test to make sure the process can pickup a ascii environment
  • Add test to make sure the process can pickup a unicode environment
  • Add properties for SECURITY_ATTRIBUTES structure
  • Add new tests for SECURITY_ATTRIBUTES structure
  • Add properties for STARTUPINFO structure
  • Add new tests for STARTUPINFO structure
  • Add tests for the various forms of input (None a non-None cases)

@opalmer opalmer added this to the 0.3.0 milestone Jun 12, 2016
@opalmer opalmer self-assigned this Jun 12, 2016
@opalmer opalmer mentioned this pull request Jun 12, 2016
Closed
37 tasks
@codecov-io
Copy link

codecov-io commented Jun 12, 2016 •
edited
Loading

Current coverage is 98.97%

Merging #98 into master will increase coverage by 0.21%

Powered by Codecov. Last updated by 1cd20fa...a9ccf72

@opalmer opalmer modified the milestones: 0.3.1, 0.3.0 Jun 27, 2016
@opalmer opalmer modified the milestones: 0.3.2, 0.3.1 Jul 3, 2016
@opalmer opalmer mentioned this pull request Jul 5, 2016
Merged
opalmer added 20 commits July 10, 2016 21:35
@opalmer
added text_to_wchar()
63f0455
@opalmer
fix default for dwCreationFlags, doc string and return type of function
98945da
@opalmer
doc string improvements
5b4bc47
@opalmer
added first basic test (need to add a few more after this)
c88fcb2
@opalmer
Merge branch 'master' of ssh://github.com/opalmer/pywincffi into crea…
b2cdbcd 
…te_process
@opalmer
bugfix for blank lpStartupInfo, returning CreateProcessResult
ffc9700
@opalmer
added hProcess/hThread properties to PROCESS_INFORMATION
d2b6a87
@opalmer
first generic process test including proper cleanup
70e6440
@opalmer
env. termination bug fix
9277a3b
@opalmer
adding tests for ascii environment
a67bf4d
@opalmer
merging with origin/master
769eff6
@opalmer
remove unnecessary keyword
7b37bf5
@opalmer
fixing tests
8acbb8f
@opalmer
added test for unicode environment
dc723b4
@opalmer
some declaration fixes
75f9483
@opalmer
adding missing url reference
3e6e8a3
@opalmer
added STARTUPINFO properties and tests
2388142
@opalmer
fixing value in InputError()
37e5c71
@opalmer
added tests for basic input validation
4664a36
@opalmer
remove unused code, adding test for working directory
a9ccf72
@opalmer opalmer merged commit be71be0 into master Jul 16, 2016
@opalmer opalmer deleted the create_process branch July 16, 2016 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@opalmer opalmer

Labels
enhancement lib: kernel32
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@opalmer @codecov-io