Add support for AWS Identity Center #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-opal
reviewed
May 25, 2023
| @@ -416,14 +411,38 @@ func resourceResourceRead(ctx context.Context, d *schema.ResourceData, m any) di | |||
| } | |||
| d.Set("reviewer_stage", reviewerStagesI) | |||
|
|
|||
| if resource.Metadata != nil { | |||
There was a problem hiding this comment.
why do we need the remote_info during the read operation? Other resources types currently don't require it, right?
There was a problem hiding this comment.
this is so that we can set the remote_info with AWS account ID and ARN when importing from terraformer, so that we can support such a workflow like this:
- Use Opal to auto-import provisioned to get permission sets into our system
- Use
terraformerto import accounts and permission sets into.tffiles, with theremote_infofilled so that the accounts can be updated (felt a bit weird to me thatremote_infoonly exists when we create new remote resources) - From there on, set app to manual import (to be added) and then use TF to manage permission sets
I imagine we can set this for other AWS Orgs resources too, but I just did permission sets for now
- Support creating and deleting permission sets - Remote info will be imported for permission sets so that the parent accounts can be referenced and modified as desired
- Updated README / remote_resource.tf - Ran `make docs`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Support creating and deleting permission sets
Remote info will be imported for permission sets so that the parent accounts can be referenced and modified as desired
Note: Build will fail until new version of the Go SDK is released.
Checklist