New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor llm Docsum #1101

Merged

chensuyue merged 33 commits into main from refactor_docsum

Jan 13, 2025

Collaborator

XinyaoWa commented Jan 2, 2025 •

edited

Loading

Description

Refactor llm Docsum

Issues

Type of change

List the type of change like below. Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would break existing design and interface)
Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

XinyaoWa requested a review from lvliang-intel as a code owner

January 2, 2025 08:29

codecov bot commented Jan 2, 2025 •

edited

Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
comps/cores/common/component.py	80.00%	2 Missing ⚠️

Files with missing lines	Coverage Δ
comps/cores/common/component.py	`84.00% <80.00%> (-4.89%)`	⬇️

XinyaoWa mentioned this pull request

Refactor docsum opea-project/GenAIExamples#1336

Merged

4 tasks

This was referenced Jan 3, 2025

Add vLLM support to DocSum Helm chart opea-project/GenAIInfra#649

Merged

[ci-auto] refactor to latest opea/llm-textgen opea-project/GenAIInfra#666

Closed

XinyaoWa and others added 7 commits

January 3, 2025 13:40


          refactor docsum

937a908

Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>


          vllm input

f15fdf9

Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>


          refine ut for docsum

2251a0f

Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>


          fix docker path for docsum

e3a8891

Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>


          for ut, duplicate with faqgen pr, can be removed later

79e3404

Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>


          fix bug

aa6fbc0

Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>


          [pre-commit.ci] auto fixes from pre-commit.com hooks

aabf059

for more information, see https://pre-commit.ci

XinyaoWa force-pushed the refactor_docsum branch from 931a0ef to aabf059 Compare

January 3, 2025 06:27

lkk12014402 reviewed

View reviewed changes

comps/llms/src/doc-summarization/integrations/opea.py Outdated Show resolved Hide resolved

XinyaoWa added 3 commits

January 9, 2025 19:52


          fix conflict

1c94d2f

Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>


          align to registry

75f2620

Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>


          fix streaming

fbdc51b

Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>

XinyaoWa requested review from letonghan, chensuyue, ZePan110 and ftian1 as code owners

January 9, 2025 12:47

pre-commit-ci bot and others added 9 commits

January 9, 2025 12:47


          [pre-commit.ci] auto fixes from pre-commit.com hooks

9d869c9

for more information, see https://pre-commit.ci


          fix bug

d95e8f3

Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>


          rename

cd6d2b2

Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>


          Merge branch 'main' into refactor_docsum

c04cad3


          Merge remote-tracking branch 'upstream/refactor_docsum' into refactor…

21a3a52

…_docsum


          Merge branch 'main' into refactor_docsum

6280eba


          fix bug

fb914f0

Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>


          fix port bug

6b829f5

Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>


          algin docsum endpoint

c30df65

Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>

eero-t reviewed

View reviewed changes

comps/llms/src/doc-summarization/integrations/langchain.py Outdated Show resolved Hide resolved

XinyaoWa and others added 5 commits

January 11, 2025 15:13


          rm vllm ut, too slow

be99d46

Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>


          refine code

8fa8404

Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>


          Merge branch 'main' into refactor_docsum

e2f9d99


          Merge remote-tracking branch 'upstream/refactor_docsum' into refactor…

7e13ca6

…_docsum


          [pre-commit.ci] auto fixes from pre-commit.com hooks

18e2ee0

for more information, see https://pre-commit.ci

lvliang-intel reviewed

View reviewed changes

comps/llms/src/doc-summarization/integrations/langchain.py Outdated Show resolved Hide resolved


          rename

e548779

Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>

ZePan110 reviewed

View reviewed changes

comps/llms/src/doc-summarization/README.md Show resolved Hide resolved

comps/llms/src/doc-summarization/README.md Outdated Show resolved Hide resolved

XinyaoWa and others added 6 commits

January 13, 2025 10:29


          fix link

f407abb

Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>


          Merge remote-tracking branch 'upstream/refactor_docsum' into refactor…

6e029f2

…_docsum


          fix conflict

93f041a

Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>


          [pre-commit.ci] auto fixes from pre-commit.com hooks

cf663ee

for more information, see https://pre-commit.ci


          Merge remote-tracking branch 'upstream/refactor_docsum' into refactor…

ab9d4da

…_docsum


          rename for ut

33f64f2

Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>

lianhao mentioned this pull request

[ci-auto] refactor opea/llm-faqgen opea-project/GenAIInfra#686

Closed

XinyaoWa added 2 commits

January 13, 2025 13:57


          Merge branch 'main' into refactor_docsum

b0e755a


          fix bug

fe7f360

Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>

ZePan110 approved these changes

View reviewed changes

chensuyue approved these changes

View reviewed changes

chensuyue merged commit 88f9373 into main

16 of 17 checks passed

chensuyue deleted the refactor_docsum branch

January 13, 2025 07:24

eero-t added a commit to eero-t/GenAIInfra that referenced this pull request


          llm-docsum-tgi/-vllm => llm-docsum

11982c5

Adapt to DocSum refactor:
opea-project/GenAIComps#1101

Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>

smguggen pushed a commit to opea-aws-proserve/GenAIComps that referenced this pull request


          Refactor llm Docsum (opea-project#1101)

e7ee87e

Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

eero-t eero-t left review comments

lkk12014402 lkk12014402 left review comments

lvliang-intel lvliang-intel left review comments

chensuyue chensuyue approved these changes

ZePan110 ZePan110 approved these changes

letonghan Awaiting requested review from letonghan letonghan is a code owner

ftian1 Awaiting requested review from ftian1 ftian1 is a code owner

Labels

None yet