Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parameter for reranker #177

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Conversation

Liangyx2
Copy link
Collaborator

@Liangyx2 Liangyx2 commented Jun 14, 2024

Description

Use parameter for reranker

Issues

n/a

Type of change

  • Breaking change (fix or feature that would break existing design and interface)

Tests

pass

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
comps/cores/proto/docarray.py 100.00% <100.00%> (ø)

@Liangyx2 Liangyx2 marked this pull request as draft June 17, 2024 02:03
@Liangyx2 Liangyx2 marked this pull request as ready for review June 17, 2024 02:18
@kevinintel
Copy link
Collaborator

please add   low-code configuration for data ingestion

@Liangyx2 Liangyx2 closed this Jun 17, 2024
@Liangyx2 Liangyx2 reopened this Jun 17, 2024
@Liangyx2 Liangyx2 marked this pull request as draft June 17, 2024 14:13
@Liangyx2 Liangyx2 marked this pull request as ready for review June 17, 2024 14:13
@Liangyx2
Copy link
Collaborator Author

please add   low-code configuration for data ingestion

solved by #159

@kevinintel kevinintel merged commit dfdd08c into opea-project:main Jun 19, 2024
10 of 11 checks passed
sharanshirodkar7 pushed a commit to sharanshirodkar7/GenAIComps that referenced this pull request Jul 9, 2024
* Use parameter for reranker

Signed-off-by: Liangyx2 <yuxiang.liang@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Liangyx2 <yuxiang.liang@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sun, Xuehao <xuehao.sun@intel.com>
Co-authored-by: chen, suyue <suyue.chen@intel.com>
Signed-off-by: sharanshirodkar7 <ssharanshirodkar7@gmail.com>
lkk12014402 pushed a commit that referenced this pull request Aug 8, 2024
Signed-off-by: letonghan <letong.han@intel.com>
Signed-off-by: lvliang-intel <liang1.lv@intel.com>
Signed-off-by: Yue, Wenjiao <wenjiao.yue@intel.com>
Signed-off-by: chensuyue <suyue.chen@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants