optional vllm microservice container build #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
ftian1
approved these changes
Jul 1, 2024
zhlsunshine
reviewed
Jul 1, 2024
XinyaoWa
approved these changes
Jul 1, 2024
chensuyue
approved these changes
Jul 2, 2024
ashahba
added a commit
to ashahba/GenAIComps
that referenced
this pull request
Jul 4, 2024
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
yogeshmpandey
pushed a commit
to yogeshmpandey/GenAIComps
that referenced
this pull request
Jul 10, 2024
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com> Signed-off-by: Yogesh Pandey <yogesh.pandey@intel.com>
dwhitena
pushed a commit
to predictionguard/GenAIComps
that referenced
this pull request
Jul 24, 2024
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com> Signed-off-by: Daniel Whitenack <whitenack.daniel@gmail.com>
lkk12014402
pushed a commit
that referenced
this pull request
Aug 8, 2024
Signed-off-by: PeterYang12 <yuhan.yang@intel.com> Co-authored-by: chen-hu-97 <hu1.chen@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds optional
build-arg's for this Dockerfile: comps/llms/text-generation/vllm/docker/Dockerfile.microserviceIssues
Current dockerfile always defaults to
gpuTorch installation whileCPUusers might not necessarily need extra packages.This leads to smaller containers for CPU users and faster build.
For users interested to do
gpubuilds all they need to do is build this image this way:Type of change
List the type of change like below. Please delete options that are not relevant.
build-argoptionARCHto buildvllm microservicecontainer for either CPU or GPU.Dependencies
None