add VDMS retriever microservice for v0.9 Milestone #539

s-gobriel · 2024-08-21T06:57:55Z

Description

Add VDMS retriever component. Targeting v0.9 milestone. Retriever is part of a megaservice for video QA RAG system.

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

[X ] New feature (non-breaking change which adds new functionality)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

new test script added to test folder. test-retrievers_langchain_vdms.sh

Signed-off-by: s-gobriel <sameh.gobriel@intel.com>

s-gobriel · 2024-08-21T06:59:14Z

@chensuyue can you please tag this PR with v0.9 milestone

Signed-off-by: s-gobriel <sameh.gobriel@intel.com>

for more information, see https://pre-commit.ci

codecov · 2024-08-21T07:51:49Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines	Coverage Δ
comps/cores/proto/docarray.py	`99.12% <100.00%> (+<0.01%)`	⬆️

Signed-off-by: BaoHuiling <huiling.bao@intel.com>

BaoHuiling · 2024-08-22T01:52:19Z

@XuhuiRen @lvliang-intel Could you help to review the code? Thanks

comps/retrievers/langchain/vdms/README.md

tests/test_retrievers_langchain_vdms.sh

Signed-off-by: s-gobriel <sameh.gobriel@intel.com>

Signed-off-by: BaoHuiling <huiling.bao@intel.com>

for more information, see https://pre-commit.ci

Signed-off-by: BaoHuiling <huiling.bao@intel.com>

comps/retrievers/langchain/vdms/docker/docker_compose_retriever.yaml

comps/retrievers/langchain/vdms/retriever_vdms.py

comps/retrievers/langchain/vdms/requirements.txt

comps/retrievers/langchain/vdms/README.md

comps/retrievers/langchain/vdms/ingest.py

lvliang-intel · 2024-08-29T13:06:49Z

@s-gobriel，
Please resolve the conflicts and fix example test issue.

Signed-off-by: s-gobriel <sameh.gobriel@intel.com>

for more information, see https://pre-commit.ci

BaoHuiling · 2024-08-30T03:58:44Z

@s-gobriel please see #538 (comment) to fix the CI test.

Signed-off-by: s-gobriel <sameh.gobriel@intel.com>

for more information, see https://pre-commit.ci

Signed-off-by: s-gobriel <sameh.gobriel@intel.com>

…-vdms-retriever

for more information, see https://pre-commit.ci

comps/retrievers/langchain/vdms/retriever_vdms.py

Signed-off-by: BaoHuiling <huiling.bao@intel.com>

BaoHuiling · 2024-09-03T05:18:50Z

does this VDMS need extra operation to index the data? It seems that this retriever is rely on VDMS vectorstore, plz add the corresponding data indexing code under "dataprep" folder. In this way, the user can get a convenient way to use this retriever and vectorstore.

Hi Xuhui, Sameh is OoO since US holiday today. @srinarayan-srikanthan is planning to raise another PR for dataprep for VDMS, on ww36'4 (ww36'3 in US).

Signed-off-by: BaoHuiling <huiling.bao@intel.com>

for more information, see https://pre-commit.ci

BaoHuiling · 2024-09-03T05:55:57Z

@s-gobriel， Please resolve the conflicts and fix example test issue.

Hi liang, the conflict and example test is good now

ttrigui · 2024-09-03T21:15:54Z

@lvliang-intel , can we please merge this PR since all issues are resolved?

add VDMS retriever microservice

3d242b8

Signed-off-by: s-gobriel <sameh.gobriel@intel.com>

s-gobriel requested review from XuhuiRen and lvliang-intel as code owners August 21, 2024 06:57

BaoHuiling mentioned this pull request Aug 21, 2024

adding VDMS retriever and test - The VDMS retriever and test are implemented in this PR. PLEASE NOTE: The input for retriever is EmbedDoc and return is SearchedDoc (these types may need to be updated for service integration) #467

Closed

4 tasks

s-gobriel and others added 2 commits August 21, 2024 00:35

add retrieval gateway and logger back to init

5840706

Signed-off-by: s-gobriel <sameh.gobriel@intel.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

b1b7f4c

for more information, see https://pre-commit.ci

chensuyue added this to the v0.9 milestone Aug 21, 2024

chensuyue and others added 3 commits August 21, 2024 23:40

Merge branch 'main' into sameh-vdms-retriever

f01ad04

use 5009 in CI

b690ea0

Signed-off-by: BaoHuiling <huiling.bao@intel.com>

Merge branch 'main' into sameh-vdms-retriever

3f8b23f

BaoHuiling requested changes Aug 26, 2024

View reviewed changes

comps/retrievers/langchain/vdms/README.md Show resolved Hide resolved

tests/test_retrievers_langchain_vdms.sh Show resolved Hide resolved

change index_name to collection_name

9991706

Signed-off-by: s-gobriel <sameh.gobriel@intel.com>

BaoHuiling approved these changes Aug 27, 2024

View reviewed changes

chensuyue modified the milestones: v0.9, v1.0 Aug 27, 2024

BaoHuiling and others added 5 commits August 27, 2024 10:15

fix var name

287d75a

Signed-off-by: BaoHuiling <huiling.bao@intel.com>

Merge branch 'main' into sameh-vdms-retriever

023a074

use index name all

dbbb415

Signed-off-by: BaoHuiling <huiling.bao@intel.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

77b7b10

for more information, see https://pre-commit.ci

add deps

e83541b

Signed-off-by: BaoHuiling <huiling.bao@intel.com>

lvliang-intel reviewed Aug 29, 2024

View reviewed changes

comps/retrievers/langchain/vdms/docker/docker_compose_retriever.yaml Outdated Show resolved Hide resolved

lvliang-intel reviewed Aug 29, 2024

View reviewed changes

comps/retrievers/langchain/vdms/retriever_vdms.py Outdated Show resolved Hide resolved

lvliang-intel reviewed Aug 29, 2024

View reviewed changes

comps/retrievers/langchain/vdms/retriever_vdms.py Outdated Show resolved Hide resolved

lvliang-intel reviewed Aug 29, 2024

View reviewed changes

comps/retrievers/langchain/vdms/requirements.txt Outdated Show resolved Hide resolved

XuhuiRen reviewed Aug 29, 2024

View reviewed changes

comps/retrievers/langchain/vdms/README.md Show resolved Hide resolved

XuhuiRen reviewed Aug 29, 2024

View reviewed changes

comps/retrievers/langchain/vdms/README.md Show resolved Hide resolved

XuhuiRen reviewed Aug 29, 2024

View reviewed changes

comps/retrievers/langchain/vdms/ingest.py Outdated Show resolved Hide resolved

BaoHuiling mentioned this pull request Aug 29, 2024

Multimodal dataprep #575

Merged

3 tasks

Merge branch 'main' into sameh-vdms-retriever

2118078

s-gobriel and others added 3 commits August 29, 2024 18:28

changes to address code reviews

0501be5

Signed-off-by: s-gobriel <sameh.gobriel@intel.com>

Merge branch 'main' into sameh-vdms-retriever

0f2262f

[pre-commit.ci] auto fixes from pre-commit.com hooks

838d1bd

for more information, see https://pre-commit.ci

This comment was marked as off-topic.

Sign in to view

BaoHuiling mentioned this pull request Aug 30, 2024

BUGFIX: fix SearchedMultimodalDoc in docarray #583

Merged

4 tasks

s-gobriel and others added 6 commits August 30, 2024 10:29

Merge branch 'main' into sameh-vdms-retriever

7586d75

resolve docarray

72ce08c

Signed-off-by: s-gobriel <sameh.gobriel@intel.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

7b727f3

for more information, see https://pre-commit.ci

add optional docarray embeddoc constraints

d45e5a1

Signed-off-by: s-gobriel <sameh.gobriel@intel.com>

Merge remote-tracking branch 'origin/sameh-vdms-retriever' into sameh…

f834685

…-vdms-retriever

[pre-commit.ci] auto fixes from pre-commit.com hooks

34dd041

for more information, see https://pre-commit.ci

BaoHuiling requested changes Sep 2, 2024

View reviewed changes

comps/retrievers/langchain/vdms/retriever_vdms.py Outdated Show resolved Hide resolved

comps/retrievers/langchain/vdms/retriever_vdms.py Outdated Show resolved Hide resolved

fix bug in comment

c7fb322

Signed-off-by: BaoHuiling <huiling.bao@intel.com>

BaoHuiling requested a review from XinyuYe-Intel as a code owner September 3, 2024 05:15

BaoHuiling and others added 3 commits September 3, 2024 13:19

Merge branch 'main' into sameh-vdms-retriever

2c89e26

import DEBUG

45079a2

Signed-off-by: BaoHuiling <huiling.bao@intel.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

5dfc745

for more information, see https://pre-commit.ci

Merge branch 'main' into sameh-vdms-retriever

f845e6c

XuhuiRen approved these changes Sep 3, 2024

View reviewed changes

BaoHuiling approved these changes Sep 4, 2024

View reviewed changes

BaoHuiling requested a review from lvliang-intel September 4, 2024 01:09

Merge branch 'main' into sameh-vdms-retriever

4ad93dc

lvliang-intel merged commit 445c9b1 into opea-project:main Sep 4, 2024
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add VDMS retriever microservice for v0.9 Milestone #539

add VDMS retriever microservice for v0.9 Milestone #539

s-gobriel commented Aug 21, 2024

s-gobriel commented Aug 21, 2024

codecov bot commented Aug 21, 2024 •

edited

Loading

BaoHuiling commented Aug 22, 2024

lvliang-intel commented Aug 29, 2024

This comment was marked as off-topic.

BaoHuiling commented Aug 30, 2024

BaoHuiling commented Sep 3, 2024

BaoHuiling commented Sep 3, 2024

ttrigui commented Sep 3, 2024

add VDMS retriever microservice for v0.9 Milestone #539

add VDMS retriever microservice for v0.9 Milestone #539

Conversation

s-gobriel commented Aug 21, 2024

Description

Issues

Type of change

Dependencies

Tests

s-gobriel commented Aug 21, 2024

codecov bot commented Aug 21, 2024 • edited Loading

Codecov Report

BaoHuiling commented Aug 22, 2024

lvliang-intel commented Aug 29, 2024

This comment was marked as off-topic.

BaoHuiling commented Aug 30, 2024

BaoHuiling commented Sep 3, 2024

BaoHuiling commented Sep 3, 2024

ttrigui commented Sep 3, 2024

codecov bot commented Aug 21, 2024 •

edited

Loading