llm-tgi: Fix to display Chinese response correctly in UI #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -82,16 +82,15 @@ async def stream_generator(): | |||
| async for text in text_generation: | |||
| stream_gen_time.append(time.time() - start) | |||
| chat_response += text | |||
| chunk_repr = repr(text.encode("utf-8")) | |||
There was a problem hiding this comment.
Encoding is required by the frontend to prevent special characters from being omitted. Have you tried the Svelte UI? We need to ensure that both the React UI and Svelte UI work seamlessly, whether in Chinese or English, with your code changes.
There was a problem hiding this comment.
Thanks for the comments! Check with Svelte UI, it can display both Chinese and English well, for it has the logic to decode hexadecimal for Chinese response. It seems that modifying React UI involves minor changes.
Helm install OPEA ChatQnA, and leverage react UI for Chinese question and answer, but it's failed to display Chinese response on UI, the output is garbled. TGI model returns the correct context, but llm-tgi microservice converts it to be messy. Add fix to address the issue. Signed-off-by: Cathy Zhang <cathy.zhang@intel.com>
bjzhjing
force-pushed
the
Fix-to-display-Chinese
branch
from
f116435
to
7571fba
Compare
for more information, see https://pre-commit.ci
|
Open opea-project/GenAIExample# and close this one. |
lkk12014402
pushed a commit
that referenced
this pull request
Sep 19, 2024
* fixed ISSUE-528 Signed-off-by: jaswanth8888 <karani.jaswanth@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: jaswanth8888 <karani.jaswanth@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helm install OPEA ChatQnA, and leverage react UI for Chinese question and answer, but it's failed to display Chinese response on react UI, the output is garbled. TGI model returns the correct context, but llm-tgi microservice converts it to be messy. Add fix to address the issue.
To fix #589