Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Pip's '--no-cache-dir' within all Dockerfiles #607

Merged
merged 5 commits into from
Sep 5, 2024

Conversation

ashahba
Copy link
Collaborator

@ashahba ashahba commented Sep 3, 2024

Description

currently a lot of Dockerfile's or scripts that run within Docker leave pip downloaded artifacts in the final container and that leads to larger than desired containers.

Issues

#265

Type of change

List the type of change like below. Please delete options that are not relevant.

  • [Y] Bug fix (non-breaking change which fixes an issue)
  • [N] New feature (non-breaking change which adds new functionality)
  • N ] Breaking change (fix or feature that would break existing design and interface)
  • [Y] Others (enhancement, documentation, validation, etc.)

Dependencies

None

Tests

All the updated containers would undergo CI.

Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@ashahba ashahba added the r1.0 label Sep 3, 2024
@ashahba ashahba changed the title Using '--no-cache-dir' within all Dockerfiles Using Pip'--no-cache-dir' within all Dockerfiles Sep 3, 2024
@ashahba ashahba changed the title Using Pip'--no-cache-dir' within all Dockerfiles Using Pip's '--no-cache-dir' within all Dockerfiles Sep 3, 2024
Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashahba ashahba merged commit f1f866f into opea-project:main Sep 5, 2024
39 of 40 checks passed
@ashahba ashahba deleted the ashahba/update-pip-installs branch September 5, 2024 19:01
@chensuyue
Copy link
Collaborator

image
We can't merge the PR without CI pass.

sharanshirodkar7 pushed a commit to predictionguard/GenAIComps that referenced this pull request Sep 11, 2024
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
lkk12014402 pushed a commit that referenced this pull request Sep 19, 2024
* Update Dockerfile to use LANGCHAIN_VERSION argument

Signed-off-by: Sun, Xuehao <xuehao.sun@intel.com>

* Revert "Update Dockerfile to use LANGCHAIN_VERSION argument"

This reverts commit 1bff239d388e06913bc82d1ee667cac5e17490ff.

* chore: Add manual freeze images workflow

Signed-off-by: Sun, Xuehao <xuehao.sun@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* split jobs

Signed-off-by: Sun, Xuehao <xuehao.sun@intel.com>

---------

Signed-off-by: Sun, Xuehao <xuehao.sun@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants