-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using Pip's '--no-cache-dir' within all Dockerfiles #607
Merged
ashahba
merged 5 commits into
opea-project:main
from
ashahba:ashahba/update-pip-installs
Sep 5, 2024
Merged
Using Pip's '--no-cache-dir' within all Dockerfiles #607
ashahba
merged 5 commits into
opea-project:main
from
ashahba:ashahba/update-pip-installs
Sep 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
ashahba
requested review from
Spycsh,
XuhuiRen,
lvliang-intel,
letonghan and
XinyuYe-Intel
as code owners
September 3, 2024 23:20
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
ashahba
changed the title
Using '--no-cache-dir' within all Dockerfiles
Using Pip'--no-cache-dir' within all Dockerfiles
Sep 3, 2024
ashahba
changed the title
Using Pip'--no-cache-dir' within all Dockerfiles
Using Pip's '--no-cache-dir' within all Dockerfiles
Sep 3, 2024
mkbhanda
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chensuyue
approved these changes
Sep 4, 2024
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
mkbhanda
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sharanshirodkar7
pushed a commit
to predictionguard/GenAIComps
that referenced
this pull request
Sep 11, 2024
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
lkk12014402
pushed a commit
that referenced
this pull request
Sep 19, 2024
* Update Dockerfile to use LANGCHAIN_VERSION argument Signed-off-by: Sun, Xuehao <xuehao.sun@intel.com> * Revert "Update Dockerfile to use LANGCHAIN_VERSION argument" This reverts commit 1bff239d388e06913bc82d1ee667cac5e17490ff. * chore: Add manual freeze images workflow Signed-off-by: Sun, Xuehao <xuehao.sun@intel.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * split jobs Signed-off-by: Sun, Xuehao <xuehao.sun@intel.com> --------- Signed-off-by: Sun, Xuehao <xuehao.sun@intel.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
currently a lot of Dockerfile's or scripts that run within Docker leave
pip
downloaded artifacts in the final container and that leads to larger than desired containers.Issues
#265
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
None
Tests
All the updated containers would undergo CI.