Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace HTTP "inprogress" gauge with megaservice "request_pending" one #864

Merged
merged 4 commits into from
Nov 13, 2024

Commits on Nov 12, 2024

  1. Add "megaservice_request_pending" metric

    Unlike other megaservice ServiceOrchestrator metrics, this covers (can
    cover) also non-streaming requests, as suggested in PR review.
    
    This does not have issues Prometheus-fastapi-instrumentator
    "inprogress" metric did:
    * Extra instances which have to be differentiated e.g. for CI
    * Rely on name -> suffix coming through obscure kwargs calls
    
    Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
    eero-t committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    5939e5e View commit details
    Browse the repository at this point in the history
  2. Remove HTTP "inprogress" gauge as redundant

    Now that ServiceOrchestrator provides pending metric.
    
    Reverts the "inprogress" metric part of commit a6998a1.
    
    Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
    eero-t committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    dfe7856 View commit details
    Browse the repository at this point in the history
  3. Document megaservice metrics

    Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
    eero-t committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    598aa30 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7daa405 View commit details
    Browse the repository at this point in the history