Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/elasticsearch vector store integration - Infosys #972

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

kkrishTa
Copy link
Contributor

@kkrishTa kkrishTa commented Dec 4, 2024

Infosys contribution to OPEA.
Elasticsearch vector store, dataprep and retriever

Description

Elasticsearch vector store integration with dataprep and retriever with components

Issues

NA

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

Langchain-elasticsearch

Tests

tests/dataprep/test_dataprep_elasticsearch_langchain.sh
tests/retrievers/test_retrievers_elasticsearch_langchain.sh

Elasticsearch vectorstore, dataprep and retriever
@joshuayao joshuayao linked an issue Dec 5, 2024 that may be closed by this pull request
@lvliang-intel
Copy link
Collaborator

@kkrishTa,
Thanks for your contribution.
Please add 'comps/dataprep/elasticsearch/langchain/Dockerfile' to '.github/workflows/docker/compose/dataprep-compose.yaml' and add 'comps/retrievers/elasticsearch/langchain/Dockerfile' to '.github/workflows/docker/compose/retrievers-compose.yaml'. These yamls are used for release images build. Then the CI issue will be fixed.

* .github fix

* return-type type-hint
@kkrishTa
Copy link
Contributor Author

kkrishTa commented Dec 9, 2024

Hello @lvliang-intel
Required changes are done to .github files. Can you please review/approve.

@ZePan110
Copy link
Collaborator

ZePan110 commented Dec 9, 2024

pre-commit.ci run

1 similar comment
@ZePan110
Copy link
Collaborator

ZePan110 commented Dec 9, 2024

pre-commit.ci run

Copy link
Collaborator

@letonghan letonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@letonghan letonghan merged commit 5ed041b into opea-project:main Dec 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] elastic search vector DB integration
5 participants