Skip to content

[BUG] TGI versions inconsistency / use of old TGI versions #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eero-t opened this issue Feb 18, 2025 · 10 comments · Fixed by #1625 · May be fixed by #1749
Open

[BUG] TGI versions inconsistency / use of old TGI versions #1563

eero-t opened this issue Feb 18, 2025 · 10 comments · Fixed by #1625 · May be fixed by #1749
Labels
A2 ready to fix Backlog bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed OPEAHack Issue created for OPEA Hackathon
Milestone

Comments

@eero-t
Copy link
Contributor

eero-t commented Feb 18, 2025

Currently latest used TGI versions in this repo are v2.3.1 (Gaudi) / v2.4.1 (CPU).

However there are several files where much older versions are used.

GenAIExamples, old CPU/rocm versions:

GenAIExamples$ git grep text-generation-inference: | grep -v -e github -e 2.[34].[01]
AudioQnA/kubernetes/gmc/README.md:- tgi-service: ghcr.io/huggingface/text-generation-inference:1.4
ChatQnA/docker_compose/nvidia/gpu/compose.yaml:    image: ghcr.io/huggingface/text-generation-inference:2.2.0
DBQnA/docker_compose/intel/cpu/xeon/README.md:docker run -d --name="test-text2sql-tgi-endpoint" --ipc=host -p $TGI_PORT:80 -v ./data:/data --shm-size 1g -e HUGGINGFACEHUB_API_TOKEN=${HUGGINGFACEHUB_API_TOKEN} -e HF_TOKEN=${HF_TOKEN} -e model=${model} ghcr.io/huggingface/text-generation-inference:2.1.0 --model-id $model
DBQnA/docker_compose/intel/cpu/xeon/compose.yaml:    image: ghcr.io/huggingface/text-generation-inference:2.1.0
DocSum/tests/test_compose_on_rocm.sh:    docker pull ghcr.io/huggingface/text-generation-inference:1.4
DocSum/tests/test_compose_on_xeon.sh:    docker pull ghcr.io/huggingface/text-generation-inference:1.4
FaqGen/tests/test_compose_on_xeon.sh:    docker pull ghcr.io/huggingface/text-generation-inference:1.4
MultimodalQnA/docker_compose/amd/gpu/rocm/compose.yaml:    image: ghcr.io/huggingface/text-generation-inference:3.0.1-rocm

GenAIComps, old CPU versions:

GenAIComps$ git grep text-generation-inference: | grep -v -e github -e 2.[34].[01]
comps/text2sql/src/README.md:docker run -d --name="text2sql-tgi-endpoint" --ipc=host -p $TGI_PORT:80 -v ./data:/data --shm-size 1g -e HF_TOKEN=${HUGGINGFACEHUB_API_TOKEN} -e model=${LLM_MODEL_ID} ghcr.io/huggingface/text-generation-inference:2.1.0 --model-id $LLM_MODEL_ID

GenAIExamples, old Gaudi versions (latest used version is 2.3.1):

$ git grep tgi-gaudi:2.0 | wc -l
40

PS. All TEI image references are for 1.5 version, i.e. consistent.

@xiguiw
Copy link
Collaborator

xiguiw commented Feb 25, 2025

@eero-t
Thanks! Good catch.

Do you have plan to submit PR to fix this?

@eero-t
Copy link
Contributor Author

eero-t commented Feb 25, 2025

Do you have plan to submit PR to fix this?

@xiguiw No.

(Fixing this could be a good "beginner" / "first time" task PR.)

@yinghu5 yinghu5 added OPEAHack Issue created for OPEA Hackathon good first issue Good for newcomers help wanted Extra attention is needed labels Feb 26, 2025
@yinghu5 yinghu5 added this to OPEA Feb 28, 2025
@yinghu5 yinghu5 added this to the v1.3 milestone Feb 28, 2025
@zhanmyz
Copy link
Contributor

zhanmyz commented Mar 6, 2025

OPEA_Team4 is working on this issue

xiaotia3 added a commit to zhanmyz/GenAIExamples that referenced this issue Mar 6, 2025

Verified

This commit was signed with the committer’s verified signature.
xiaotia3 Xiaotian Chen
- Update TGI CPU/rocm version to v2.4.1
- Update TGI Gaudi version to v2.3.1

Fixes opea-project#1563

Signed-off-by: xiaotia3 <xiaotian.chen@intel.com>
Signed-off-by: Ma, YaZhan <yazhan.ma@intel.com>
Signed-off-by: Gao, Fengqian <fengqian.gao@intel.com>
Signed-off-by: Wang, Le3 <le3.wang@intel.com>
xiaotia3 added a commit to zhanmyz/GenAIExamples that referenced this issue Mar 6, 2025

Verified

This commit was signed with the committer’s verified signature.
xiaotia3 Xiaotian Chen
- Update TGI CPU/rocm version to v2.4.1
- Update TGI Gaudi version to v2.3.1

Fixes opea-project#1563

Signed-off-by: xiaotia3 <xiaotian.chen@intel.com>
Signed-off-by: Ma, Yazhan <yazhan.ma@intel.com>
Signed-off-by: Gao, Fengqian <fengqian.gao@intel.com>
Signed-off-by: Wang, Le3 <le3.wang@intel.com>
@xiaotia3 xiaotia3 mentioned this issue Mar 6, 2025
4 tasks
@joshuayao joshuayao moved this to In progress in OPEA Mar 24, 2025
@joshuayao joshuayao moved this from In progress to In review in OPEA Mar 24, 2025
xiaotia3 added a commit to zhanmyz/GenAIExamples that referenced this issue Mar 25, 2025

Verified

This commit was signed with the committer’s verified signature.
xiaotia3 Xiaotian Chen
- Update TGI CPU/rocm version to v2.4.1
- Update TGI Gaudi version to v2.3.1

Fixes opea-project#1563

Signed-off-by: xiaotia3 <xiaotian.chen@intel.com>
Signed-off-by: Ma, Yazhan <yazhan.ma@intel.com>
Signed-off-by: Gao, Fengqian <fengqian.gao@intel.com>
Signed-off-by: Wang, Le3 <le3.wang@intel.com>
@yinghu5 yinghu5 added the A2 ready to fix label Mar 26, 2025
@yinghu5
Copy link
Collaborator

yinghu5 commented Mar 26, 2025

Hi @xiaotia3 thank you a lot for the contribution. will remind team to review. thanks

@eero-t
Copy link
Contributor Author

eero-t commented Mar 31, 2025

PS. All TEI image references are for 1.5.0 version, i.e. consistent.

But somewhat out of date. 1.5.0 was released last summer, whereas latest tei-gaudi release is 1.5.3 (and "GenAIComps" project use 1.5.2): https://github.com/huggingface/tei-gaudi/releases

@github-project-automation github-project-automation bot moved this from In review to Done in OPEA Apr 1, 2025
@eero-t
Copy link
Contributor Author

eero-t commented Apr 1, 2025

GenAIComps CPU/rocm TGI is now consistent version, but this repo is not quite done yet, there's still lot of discrepancy.

While most are now on TGI 2.4.x, some references to older version still exist:

GenAIExamples$ git grep text-generation-inference: | wc -l
87
GenAIExamples$ git grep text-generation-inference: | grep -v 2.4.1 | wc -l
55
GenAIExamples$ git grep text-generation-inference: | grep -v 2.4 | wc -l
20

Same thing with Gaudi version:

GenAIExamples$ git grep /tgi-gaudi: | wc -l
51
GenAIExamples$ git grep /tgi-gaudi: | grep -v 2.3.1 | wc -l
8

Also in GenAIComps:

GenAIComps$ git grep /tgi-gaudi: | wc -l
10
GenAIComps$ git grep /tgi-gaudi: | grep -v 2.3.1 | wc -l
4

@chensuyue please re-open.

@chensuyue chensuyue reopened this Apr 2, 2025
@chensuyue
Copy link
Collaborator

@xiaotia3 will you continue submit PR for this issue?

@xiaotia3
Copy link
Contributor

xiaotia3 commented Apr 2, 2025

@xiaotia3 will you continue submit PR for this issue?

I will. The old version images that still exist were likely introduced during the period when the PR was trying to be merged. Let me update them.

And due to known issues, ChatQnA and AvatarChatbot may not be updated , is it ok?

@eero-t
Copy link
Contributor Author

eero-t commented Apr 2, 2025

And due to known issues, ChatQnA and AvatarChatbot may not be updated , is it ok?

Those can be updated in a separate PR after their issues have been fixed.

@xiaotia3 xiaotia3 linked a pull request Apr 3, 2025 that will close this issue
4 tasks
@joshuayao joshuayao linked a pull request Apr 15, 2025 that will close this issue
4 tasks
@joshuayao joshuayao moved this from Done to In review in OPEA Apr 15, 2025
@joshuayao joshuayao added the bug Something isn't working label Apr 16, 2025
@xiguiw
Copy link
Collaborator

xiguiw commented Apr 16, 2025

OPEA_Team4 is working on this issue

@zhanmyz @xiaotia3
@1625 is merged.

Thanks for your contributions.
Found two TGI images.

Would you please help on this? Thanks!

GenAIExample
DocSum/tests/test_compose_tgi_on_xeon.sh: docker pull ghcr.io/huggingface/text-generation-inference:1.4

GenAIComp
comps/text2sql/src/README.md: docker run -d --name="text2sql-tgi-endpoint" --ipc=host -p T G I P O R T : 80 v . / d a t a : / d a t a s h m s i z e 1 g e H F T O K E N = {HUGGINGFACEHUB_API_TOKEN} -e model=${LLM_MODEL_ID} ghcr.io/huggingface/text-generation-inference:2.1.0 --model-id $LLM_MODEL_ID

@joshuayao joshuayao modified the milestones: v1.3, v1.4 Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 ready to fix Backlog bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed OPEAHack Issue created for OPEA Hackathon
Projects
Status: In review
7 participants