Add EdgeCraftRag as a GenAIExample #1072
Conversation
There was a problem hiding this comment.
looks like the edgecraftrag folder contains an entire solution of rag server, from the component to the pipeline construction, which is overlapped with OPEA design. OPEA design philosophy is trying to abstract those common component for enterprise use and the pipeline construction is done in OPEA mega service. I am not sure if there are values to introduce another pipeline implementation. and you also invokes GenAIComps.core.register_microservice() API in your implementation, which shouldn't happen. we only register OPEA microservice for those common components and should put under GenAIComps repo but not here.
Yongbozzz
force-pushed
the
ecrag_v1
branch
2 times, most recently
from
61cf9bd to
58865a2
Compare
@ftian1 Thanks for your comment, as mentioned in the RFC, the goal of this example is to make a RAG solution specifically for edge use cases, which includes these characteristics:
Thus, we are building the pipeline as a solution for now to 1) eliminate some of the microservices setup 2) implement each of the stages in the pipeline to meet edge specific needs. Moving on, we are happy to contribute these implementations to GenAIComps. We are showcasing that OPEA can integrate with existing solutions by just replacing some of the components with OPEA microservices (Like LLM in this case). With that, I don't think it's an overlap for the implementation. We are NOT trying to change the way of building the pipeline in OPEA. As to the register_microservice() API, we're okay to use another API serving framework and will update soon. |
Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: chensuyue <suyue.chen@intel.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…an up issue (opea-project#1068) Signed-off-by: chensuyue <suyue.chen@intel.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Zhu, Yongbo <yongbo.zhu@intel.com>
Signed-off-by: Zhu, Yongbo <yongbo.zhu@intel.com>
Signed-off-by: chensuyue <suyue.chen@intel.com>
Signed-off-by: Zhu, Yongbo <yongbo.zhu@intel.com>
Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: chensuyue <suyue.chen@intel.com>
for more information, see https://pre-commit.ci
Signed-off-by: Wang, Xigui <xigui.wang@intel.com>
Signed-off-by: Zhu, Yongbo <yongbo.zhu@intel.com>
for more information, see https://pre-commit.ci
|
@Yongbozzz, |
EdgeCraftRAG/edgecraftrag/api_schema.py:9: ModelIn ==> modeling, model in ModelIn is a type, can this be ignored? |
Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: chensuyue <suyue.chen@intel.com>
for more information, see https://pre-commit.ci
Signed-off-by: Zhu, Yongbo <yongbo.zhu@intel.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Signed-off-by: Zhu, Yongbo <yongbo.zhu@intel.com>
Signed-off-by: Zhu, Yongbo <yongbo.zhu@intel.com>
Signed-off-by: Zhu, Yongbo <yongbo.zhu@intel.com>
for more information, see https://pre-commit.ci
Signed-off-by: Zhu, Yongbo <yongbo.zhu@intel.com>
Signed-off-by: Zhu, Yongbo <yongbo.zhu@intel.com>
Signed-off-by: Zhu, Yongbo <yongbo.zhu@intel.com>
|
I am ok with the overall design. pls fix the comments provided by suyue |
…into ecrag_v1 Signed-off-by: Zhu, Yongbo <yongbo.zhu@intel.com>
Hi Tian Feng, I have resolve the comments provided by suyue and will add e2e test after merge (aligned with suyue), thanks |
Signed-off-by: Zhu, Yongbo <yongbo.zhu@intel.com>
Description
Edge Craft RAG (EC-RAG) is a customizable, tunable and production-ready Retrieval-Augmented Generation system for edge solutions. It is designed to curate the RAG pipeline to meet hardware requirements at edge with guaranteed quality and performance.
Issues
N/A
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
langchain-core, llama-index
Tests
Related RFC
https://opea-project.github.io/latest/community/rfcs/24-08-21-GenAIExample-002-Edge_Craft_RAG.html