-
Notifications
You must be signed in to change notification settings - Fork 314
Fix conversational UI setup #1672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conversational UI setup #1672
Conversation
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- ChatQnA/docker_compose/intel/cpu/xeon/use_conversation_ui.sh: Language not supported
- ChatQnA/tests/test_conversation_ui_setup.sh: Language not supported
correct the location Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
fi | ||
|
||
# Source environment variables | ||
source ./set_env.sh[[3](https://www.google.com/url?sa=E&q=https%3A%2F%2Fvertexaisearch.cloud.google.com%2Fgrounding-api-redirect%2FAQXblrzJdVR5EXosjXbjSi13_w8_AjDsxY1z8tpwlX2Ht4FdLy1NFE8mDnpUWrLd1KeksZBRzGExdccSmovlOVd5GIk44_Ibde4YqSvt0wI6BvhM3TOJUVyxcWF7BH0XBGtNMn3rQueGW5X0aAetveHZAe6Q6d_fzeFIwluKFo_DQe-i)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why here has the [3]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have cleaned it up, it's not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the redundant links.
Removed trailing reference links.
for more information, see https://pre-commit.ci
Hi @surfiniaburger, |
Hi @surfiniaburger, Then I close the PR, but thank you very much for your PRs and continuous contribution. |
Fix conversational UI setup in ChatQnA (Draft)
This PR addresses [
https://github.com/opea-project/GenAIExamples/issues/921#issuecomment-2723958947
]. It provides a script (use_conversation_ui.sh
) to automate switching to the conversational UI, along with a Bash test script (test_conversation_ui_setup.sh
).Important Note: I am currently unable to test these changes due to system limitations (Docker installation issues and low memory). I will be able to test thoroughly in approximately 1-2 months when I have a new system. I am submitting this as a Draft PR to:
Changes Made:
use_conversation_ui.sh
to automate the setup process, addressing inconsistencies in the README.test_conversation_ui_setup.sh
(Bash) to verify the changes made by the script.compose.yaml
as described in the issue and script.README.md
Testing Status:
yq
to be installed to run the test script,sudo apt install yq
.Next Steps (for me):
Request to Maintainers:
Thank you for your understanding!