Integrate DocSum set_env to ut scripts. #1860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZePan110
requested review from
XinyaoWa,
XinyuYe-Intel,
letonghan and
lkk12014402
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR integrates the setting of environment variables into test scripts by adding README.md files for InstructionTuning and DocSum test directories.
- Added a README.md in InstructionTuning/tests outlining environment variable setup and test execution instructions.
- Added an extended README.md in DocSum/tests with several test execution options on different hardware setups.
Reviewed Changes
Copilot reviewed 2 out of 10 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| InstructionTuning/tests/README.md | New file with instructions to set env variables and run tests on Xeon. |
| DocSum/tests/README.md | New file with detailed instructions to set env variables and execute tests on multiple hardware setups. |
Files not reviewed (8)
- DocSum/docker_compose/amd/gpu/rocm/set_env_vllm.sh: Language not supported
- DocSum/docker_compose/set_env.sh: Language not supported
- DocSum/tests/test_compose_on_gaudi.sh: Language not supported
- DocSum/tests/test_compose_on_rocm.sh: Language not supported
- DocSum/tests/test_compose_on_xeon.sh: Language not supported
- DocSum/tests/test_compose_tgi_on_gaudi.sh: Language not supported
- DocSum/tests/test_compose_tgi_on_xeon.sh: Language not supported
- DocSum/tests/test_compose_vllm_on_rocm.sh: Language not supported
Comments suppressed due to low confidence (2)
InstructionTuning/tests/README.md:1
- [nitpick] The header 'Translation E2E test scripts' may be inconsistent with the PR title which mentions UT scripts. Consider revising the header to clarify the scope and purpose of the test scripts.
# Translation E2E test scripts
DocSum/tests/README.md:1
- [nitpick] The header 'Translation E2E test scripts' might not accurately reflect the intended use as described in the PR metadata. Consider updating the header for consistency with the integration of UT scripts.
# Translation E2E test scripts
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: ZePan110 <ze.pan@intel.com>
yinghu5
reviewed
Apr 24, 2025
yinghu5
changed the title
lvliang-intel
approved these changes
Apr 28, 2025
yongfengdu
pushed a commit
to yongfengdu/GenAIExamples
that referenced
this pull request
May 8, 2025
Integrate DocSum set_env to ut scripts. Add README.md for DocSum and InstructionTuning UT scripts. Signed-off-by: ZePan110 <ze.pan@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrate DocSum set_env to ut scripts.
Add README.md for DocSum and InstructionTuning UT scripts.
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.