Skip to content

Refine README.MD for SearchQnA on AMD ROCm platform #1876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

artem-astafev
Copy link
Contributor

@artem-astafev artem-astafev commented Apr 24, 2025

Description

Refine readme of SearchQnA for AMD ROCm docker compose deployment

Issues

#1685

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

None

Tests

None

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Artem Astafev <a.astafev@datamonsters.com>
Copy link

github-actions bot commented Apr 24, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

pre-commit-ci bot and others added 2 commits April 24, 2025 05:16
for more information, see https://pre-commit.ci
@lvliang-intel lvliang-intel added documentation Improvements or additions to documentation v1.3 labels Apr 24, 2025
Signed-off-by: Artem Astafev <a.astafev@datamonsters.com>
@yinghu5 yinghu5 requested review from yinghu5 and Copilot April 25, 2025 01:30
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines the README.md file for deploying SearchQnA on the AMD ROCm platform, with a focus on clarifying single node deployment instructions using both vLLM and TGI inference types.

  • Updated title and introductory text for clarity
  • Revised table of contents and deployment step order
  • Expanded environment configuration and validation instructions for each inference type

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Collaborator

@yinghu5 yinghu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@lvliang-intel lvliang-intel merged commit ccc145e into opea-project:main Apr 25, 2025
9 checks passed
chensuyue pushed a commit that referenced this pull request Apr 25, 2025
Signed-off-by: Artem Astafev <a.astafev@datamonsters.com>
(cherry picked from commit ccc145e)
yongfengdu pushed a commit to yongfengdu/GenAIExamples that referenced this pull request May 8, 2025
Signed-off-by: Artem Astafev <a.astafev@datamonsters.com>
chyundunovDatamonsters pushed a commit to chyundunovDatamonsters/OPEA-GenAIExamples that referenced this pull request May 16, 2025
Signed-off-by: Artem Astafev <a.astafev@datamonsters.com>
Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation v1.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants