-
Notifications
You must be signed in to change notification settings - Fork 293
update secrets token name for AgentQnA. #2023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: ZePan110 <ze.pan@intel.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
The PR standardizes the environment variable name for HuggingFace tokens across scripts, Docker/YAML configs, Helm charts, workflows, and documentation.
- Replaces
HUGGINGFACEHUB_API_TOKEN
withHF_TOKEN
in all test and launch scripts - Updates Docker Compose and Helm chart environment keys to use the new variable
- Adjusts GitHub workflows and README files to reference
HF_TOKEN
consistently
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
AgentQnA/tests/*.sh | Updated export of HF_TOKEN in various scripts |
AgentQnA/retrieval_tool/launch_retrieval_tool.sh | Swapped legacy token var for HF_TOKEN |
AgentQnA/docker_compose/**/*.{sh,yaml} | Changed environment var references to HF_TOKEN |
AgentQnA/kubernetes/helm/README.md | Updated Helm install to use HF_TOKEN |
AgentQnA/README.md | Updated token export example to HF_TOKEN |
.github/workflows/_run-docker-compose.yml | Swapped secrets to HF_TOKEN |
.github/workflows/_helm-e2e.yml, _gmc-e2e.yml | Updated workflows to reference HF_TOKEN |
Comments suppressed due to low confidence (5)
.github/workflows/_helm-e2e.yml:169
- The environment variable
HFTOKEN
lacks the underscore and is inconsistent withHF_TOKEN
used elsewhere. Rename it toHF_TOKEN
for consistency.
HFTOKEN: ${{ secrets.HF_TOKEN }}
.github/workflows/_helm-e2e.yml:193
- Using
${HFTOKEN}
here may be broken if the variable was renamed toHF_TOKEN
. Update this reference to${HF_TOKEN}
.
--set global.HF_TOKEN=${HFTOKEN} \
AgentQnA/docker_compose/intel/hpu/gaudi/compose.yaml:19
- The container key
HUGGINGFACEHUB_API_TOKEN
remains legacy—consider renaming it toHF_TOKEN
(or the app’s expected key) to reflect the new standard.
HUGGINGFACEHUB_API_TOKEN: ${HF_TOKEN}
AgentQnA/docker_compose/amd/gpu/rocm/compose_vllm.yaml:14
- Both
HUGGINGFACEHUB_API_TOKEN
andHF_TOKEN
are declared for the same value—remove the legacyHUGGINGFACEHUB_API_TOKEN
entry to avoid redundancy.
HF_TOKEN: ${HF_TOKEN}
AgentQnA/kubernetes/helm/README.md:7
- The example uses
HFTOKEN
but other docs and scripts referenceHF_TOKEN
. Update this toexport HF_TOKEN=
for consistency.
export HFTOKEN="insert-your-huggingface-token-here"
Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: ZePan110 <ze.pan@intel.com> Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com>
Description
Issues
#1954
#1999
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.