-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new DocIndexRetriever example #405
Conversation
@minmin-intel @ftian1 @lvliang-intel , please take a look |
Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
ee907e6
to
efa8275
Compare
for more information, see https://pre-commit.ci
Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
eb91097
to
9f73f29
Compare
Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
9f73f29
to
484a033
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xuechendi It seems the new GenAI example could be part of ChatQnA (RAG). Does it make sense to improve ChatQnA to add this example?
@hshen14 , thanks for the review. If we use ChatQnA directly, we will need to provide different Spec from ChatQnA with different chatQnA megaflow to only enable RAG part. Either way is working for me, but I felt adding a new example is clearer. Also, we can support more than one optional vectorstore backend in RAG megaservice for different scenarios. |
We are now having Agent example. Since it's designed to be used by Agent, how about moving under Agent? |
Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
for more information, see https://pre-commit.ci
Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
120d1b0
to
770e7b2
Compare
@kevinintel , can you help to '@' the right person who should review/approve this PR. |
* Add DocIndexRetriever example Signed-off-by: Chendi.Xue <chendi.xue@intel.com> --------- Signed-off-by: Chendi.Xue <chendi.xue@intel.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: XuhuiRen <44249229+XuhuiRen@users.noreply.github.com>
…format (opea-project#405) Co-authored-by: sys-lpot-val <sys_lpot_val@intel.com> Co-authored-by: lvliang-intel <liang1.lv@intel.com>
Description
Add a new example for only add data to vector store and retrieve from vector store
related AIComps change:
opea-project/GenAIComps#314
Issues
n/a
.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
No
Tests
No