Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all xeon tgi image version consistent #851

Merged
merged 14 commits into from
Sep 24, 2024
Merged

Make all xeon tgi image version consistent #851

merged 14 commits into from
Sep 24, 2024

Conversation

zhlsunshine
Copy link

Description

Make all xeon tgi image version consistent

Issues

n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

n/a.

Tests

n/a.

make all xeon tgi image version consistent.
a36be08 
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
zhlsunshine added 2 commits September 19, 2024 18:23
using ghcr.io/huggingface/text-generation-inference:sha-e4201f4-intel…
c1b24d8 
…-cpu as the tgi image on xeon.

Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
@zhlsunshine
Copy link
Author

Hi @lvliang-intel, as we discussed, let's use ghcr.io/huggingface/text-generation-inference:sha-e4201f4-intel-cpu as the tgi image on xeon for all examples.

@zhlsunshine zhlsunshine mentioned this pull request Sep 19, 2024
Merged
3 tasks
@yinghu5 yinghu5 requested review from yinghu5 and chensuyue and removed request for yinghu5 September 19, 2024 14:12
@chensuyue chensuyue modified the milestone: v1.1 Sep 19, 2024
change the tgi image version for tgi.
564615c 
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
change from sha-e4201f4-intel-cpu to latest-intel-cpu.
294a6dd 
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
@zhlsunshine
Copy link
Author

Hi @lvliang-intel, I replace the ghcr.io/huggingface/text-generation-inference:sha-e4201f4-intel-cpu with ghcr.io/huggingface/text-generation-inference:latest-intel-cpu

lianhao
lianhao suggested changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@lianhao lianhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the CI manifest test is missing? We need them to make sure it's working

@zhlsunshine
Copy link
Author

Hi @lvliang-intel @lianhao @chensuyue, after discussed with Intel Xeon TGI image support engineer, we'd better to use the specified version of TGI image, such as ghcr.io/huggingface/text-generation-inference:sha-e4201f4-intel-cpu, instead ghcr.io/huggingface/text-generation-inference:latest-intel-cpu which would update every day.

@chensuyue
Copy link
Collaborator

Please resolve the conflicts.

fix conflicts.
4e8c77c 
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
@zhlsunshine
Copy link
Author

Please resolve the conflicts.

Hi @chensuyue sure, done!

@chensuyue chensuyue merged commit 954a220 into opea-project:main Sep 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvliang-intel lvliang-intel lvliang-intel approved these changes

@lianhao lianhao lianhao requested changes

@chensuyue chensuyue chensuyue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@zhlsunshine @chensuyue @lianhao @lvliang-intel