-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align HPU parameters with docker compose #528
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ChatQnA guardrails is also using rerank, so limits need to be increased for that too:
https://github.com/opea-project/GenAIInfra/blob/main/helm-charts/chatqna/guardrails-gaudi-values.yaml
And shouldn't the other updates from docker compose files be applied there too?
After that, commit & PR could state that it fixes also #487.
PS. GitHub Actions complaint could be fixed just by removing the commented out probes alternative, as it will remain in Git history.
@yongfengdu Since you're syncing between GenAIExamples and GenAIInfra, could you please address the issue #530 in this same PR at the same time? Thanks! There is another guardrail-gaudi-values.yaml in chatqna which may need to be modified too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also we need to enable ci-gaudi test for teirerank too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Dolpher Du <dolpher.du@intel.com> Signed-off-by: ZhangJianyu <zhang.jianyu@outlook.com>
Signed-off-by: Dolpher Du <dolpher.du@intel.com>
Description
Align parameters with docker compose version
Issues
Fixes #499, Fixes #487, Fixes #530
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Helm install