Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Added automated provisioning of CosmosDB and App Insights for OPEA applications - Infosys #657

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kkrishTa
Copy link
Contributor

Description

Infosys contribution to OPEA.
Added CosmosDB and App Insights to the terraform on Azure.

Issues

NA

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

None

Tests

Tested terraforms on Azure platform.

Signed-off-by: kkrishTa <Kamalakara_T@infosys.com>
Signed-off-by: kkrishTa <Kamalakara_T@infosys.com>
Signed-off-by: kkrishTa <Kamalakara_T@infosys.com>
@lianhao lianhao requested review from poussa and removed request for daisy-ycguo December 25, 2024 07:04
Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few questions

indexing_mode = "consistent"

included_path {
path = "/*"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not /* cover everything? Is there some ordering effect here .. from most general to specific?

name = "workspace-${var.cluster_name}"
location = azurerm_resource_group.main.location
resource_group_name = azurerm_resource_group.main.name
sku = "PerGB2018"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really want to hard code sku or keep it a variable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants