Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ymlr is optional but locked at ~> 2.0 #500

Closed
thbar opened this issue Sep 27, 2022 · 3 comments
Closed

ymlr is optional but locked at ~> 2.0 #500

thbar opened this issue Sep 27, 2022 · 3 comments

Comments

@thbar
Copy link
Contributor

thbar commented Sep 27, 2022

Hello! The library locks the ymlr version here:

open_api_spex/mix.exs

Line 65 in def1794

{:ymlr, "~> 2.0", optional: true}

but ymlr is now available in v3:

https://github.com/ufirstgroup/ymlr/blob/main/CHANGELOG.md

I wonder if the version constraint could be softened here?
@zorbash
Copy link
Contributor

zorbash commented Sep 27, 2022

Sure, can you provide a PR?

thbar added a commit to thbar/open_api_spex that referenced this issue Sep 30, 2022
@thbar
Relax dependency constraint on ymlr open-api-spex#500
d795801
@thbar thbar mentioned this issue Sep 30, 2022
Merged
@thbar
Copy link
Contributor Author

thbar commented Sep 30, 2022

@zorbash ready in #502!

zorbash pushed a commit that referenced this issue Oct 2, 2022
@thbar
Relax dependency constraint on ymlr #500 (#502)
057d6de
gmile pushed a commit to gmile/open_api_spex that referenced this issue Oct 3, 2022
@thbar @gmile
Relax dependency constraint on ymlr open-api-spex#500 (open-api-spex#502
68ecf9e 
)

According to OpenAPI spec v3.1, strings of format "byte" contain
base64-encoded values
@mbuhot
Copy link
Collaborator

mbuhot commented Oct 3, 2022

Fixed in #502, thanks @thbar 👍

@mbuhot mbuhot closed this as completed Oct 3, 2022
@arcanemachine arcanemachine mentioned this issue Jun 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thbar @mbuhot @zorbash