Add operation lookup by phoenix {controller, action} #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbuhot
force-pushed
the
lookup-operation-by-phoenix-controller-action
branch
2 times, most recently
from
dbe879d to
e68f25f
Compare
|
These changes may also be helpful for #72, we could have a no-op Cache adapter in |
This optimization avoids having to call open_api_operation(action) in each call to CastAndValidate for phoenix controllers. The caching behaviour is moved into a separate module, and updated from CastAndValidate the first time a phoenix controller/action is used to resolve an Operation.
mbuhot
force-pushed
the
lookup-operation-by-phoenix-controller-action
branch
from
e68f25f to
74bf213
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimization avoids having to call
controller.open_api_operation(action)in each call to
CastAndValidatefor phoenix controllers.The caching behaviour is moved into a separate module
OpenApiSpex.Plug.Cache, andupdated from
CastAndValidatethe first time a phoenix controller/actionis used to resolve an Operation.
With this optimization in place, it becomes reasonable to use the
@docbasedOperationdefinitions accessed withCode.fetch_docs/1at runtime.