Improve CI pipeline #377
Merged
Improve CI pipeline #377
+305
−253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacorti
force-pushed
the
feature/improve-ci
branch
2 times, most recently
from
b38afa3 to
386eb3a
Compare
mbuhot
reviewed
Aug 2, 2021
examples/phoenix_app/lib/phoenix_app_web/controllers/oauth_controller.ex
Outdated
Show resolved
Hide resolved
mbuhot
reviewed
Aug 2, 2021
mbuhot
reviewed
Aug 2, 2021
mbuhot
reviewed
Aug 2, 2021
mbuhot
reviewed
Aug 2, 2021
mbuhot
reviewed
Aug 2, 2021
lucacorti
force-pushed
the
feature/improve-ci
branch
from
8b87f1d to
df6fd5d
Compare
|
@mbuhot I've reverted the changes and put together a minimal set to make credo pass. I've also disabled the problematic style check. Let me know if this looks acceptable to you. |
lucacorti
force-pushed
the
feature/improve-ci
branch
from
155bb79 to
8f064de
Compare
lucacorti
force-pushed
the
feature/improve-ci
branch
from
3fa4fe9 to
40fca1c
Compare
|
I've rebased this to latest master and updated CI. Thoughts? |
zorbash
reviewed
May 10, 2022
mbuhot
reviewed
May 23, 2022
| @@ -193,7 +193,7 @@ defmodule OpenApiSpex.Plug.SwaggerUI do | |||
| end | |||
|
|
|||
| defp supplement_config(%{oauth2_redirect_url: {:endpoint_url, path}} = config, conn) do | |||
| endpoint_module = apply(Phoenix.Controller, :endpoint_module, [conn]) | |||
| endpoint_module = Phoenix.Controller.endpoint_module(conn) | |||
There was a problem hiding this comment.
Does this compile in prod env? OpenApiSpex should work in plain plug projects that don't use phoenix.
This was referenced Jul 13, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This improves the CI pipeline by:
I also fixed what appears to be a bug (null description in controller operation) while at it.