Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bibliography to pdoc-generated docs (json file with all mentioned papers identified by DOIs and cross-checked with code within CI workflow) #498

Merged
merged 13 commits into from
Jan 21, 2025

Conversation

pawelmagnu
Copy link
Collaborator

No description provided.

@pawelmagnu
Copy link
Collaborator Author

@slayoo there are some problems with matlab test, could you help with that?
Error: Version 3.8 with arch x64 not found

@slayoo slayoo changed the title add bibliography add bibliography to pdoc-generated docs (json file with all mentioned papers identified by DOIs and cross-checked with code within CI workflow) Jan 19, 2025
@slayoo
Copy link
Member

slayoo commented Jan 19, 2025

@slayoo there are some problems with matlab test, could you help with that? Error: Version 3.8 with arch x64 not found

Addressed in #500

@pawelmagnu
Copy link
Collaborator Author

@slayoo there seems to be an error importing nbformat, could you look into that?

@slayoo
Copy link
Member

slayoo commented Jan 20, 2025

@slayoo there seems to be an error importing nbformat, could you look into that?

the change in bfb5010 adds a line that was there in PySDM workflow, which makes it work.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (f006acd) to head (bfb5010).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #498   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files          30       30           
  Lines        1468     1468           
=======================================
  Hits         1351     1351           
  Misses        117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pawelmagnu
Copy link
Collaborator Author

can we merge @slayoo

@slayoo
Copy link
Member

slayoo commented Jan 21, 2025

@pawelmagnu, we're still missing labels, hence the bibliography is not sorted, and likely unintuitive without paper authors mentioned in the list. I'll add the labels in a moment...

@slayoo slayoo added this pull request to the merge queue Jan 21, 2025
@slayoo
Copy link
Member

slayoo commented Jan 21, 2025

KUDOS @pawelmagnu !

Merged via the queue into open-atmos:main with commit 77a1c55 Jan 21, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants