improve test coverage for impl.Mesh and products.SufracePrecipitation; introduce Mesh.domain_bottom_surface_area; switch from volume to mass for rainfall counting; improve docstrings (default length of omitted dims, liquid/ice phase). closes #708 #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slayoo
changed the title
…area; switch from volume to mass for rainfall counting; improve docstrings (default lengt of omitted dims, liquid/ice phase)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1399 +/- ##
==========================================
+ Coverage 84.75% 84.90% +0.14%
==========================================
Files 375 375
Lines 9249 9252 +3
==========================================
+ Hits 7839 7855 +16
+ Misses 1410 1397 -13 ☔ View full report in Codecov by Sentry. |
slayoo
changed the title
slayoo
changed the title
slayoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.