Aqueous chemistry products and attributes and new example draft: Kreidenweis et al #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry merge (based on PR by Grzegorz Łazarski)
…_example_Kreidenweis_et_al
…es in AqueousChemistry::dissolve_env_gases; constants.g -> constants.g_std; renaming amount -> mole_amount; g as an optional parameter for parcel; more tests for Kreidenweis example; new hydrostatic density solution in parcel env
…_example_Kreidenweis_et_al
…e, one more TODO in radius, hydrogen_conc_factory, renaming RH->RH_env
… GASEOUS_COMPOUNDS & AQUEOUS_COMPOUNDS
…_example_Kreidenweis_et_al � Conflicts: � PySDM_examples/Arabas_and_Shima_2017_Fig_5/simulation.py � PySDM_tests/smoke_tests/Yang_et_al_2018_Fig_2/test_just_do_it.py
…saturation histogram in B_et_al_2021 demo; fixing dt_range handling in condensation methods
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
===========================================
+ Coverage 60.86% 79.36% +18.49%
===========================================
Files 130 145 +15
Lines 3613 4046 +433
===========================================
+ Hits 2199 3211 +1012
+ Misses 1414 835 -579
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.