attempt getting rid date-fns-tz in prod build

[Sakai-san]

Using @neonnoon approach for converting a date with time zone A to date with time zone B, using built-in JavaScript utility was a better approach then import third-party lib.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[neonnoon]

Can you elaborate why you prefer going for this variant? Basically you're saying you're trusting browsers to implement en-us properly (so you can use it to parse and build the manual date), but not de?

If the only reason is not having node 14 available on the (to be deprecated) internal CI, I don't quite see the point.

Anyway, I think I am missing some context of internal discussions you're having, from my point of view we're going a bit in circles.

[Sakai-san]

Anyway, I think I am missing some context of internal discussions you're having, from my point of view we're going a bit in circles.

Hi @neonnoon. Ok let me give some context. It relates to the a recent merged PR actually.
The basic idea is to not use third party library while built-in JS object do the same job (like you did in the past).

The language de, en-US does not matter much. Indeed we do have our own format anyway, namely 'dd.MM.yyyy, HH:mm'.

The only problem with de is that it seems not to be in node 12. What is important is that the built-in JS feature convert the date into different time zone (including summer time) and thus we can skip importing date-fns-tz.

The present PR is nothing but a proposal. If there no need I ll close it. All good.

[neonnoon]

The basic idea is to not use third party library while built-in JS object do the same job (like you did in the past).

Exactly, but then we reverted that. And now we're reverting the revert. Which is why I think we're going in circles. 😄

The language de, en-US does not matter much. Indeed we do have our own format anyway, namely 'dd.MM.yyyy, HH:mm'.

'dd.MM.yyyy, HH:mm' is actually de, just without seconds.

Again, no strong opinion either way. But I think we should come to a conclusion and an end with this topic eventually.

[Sakai-san]

Again, no strong opinion either way. But I think we should come to a conclusion and an end with this topic eventually.

@neonnoon Ok. Cool. Thanks for your feedback. Alles i.O.

[neonnoon]

✌️