`setInput` cannot handle null/undefined values on nullish object fields

[Huliiiiii]

Calling setInput to set a nullish object field to null or undefined will result in a runtime error.

That's because setFieldInput internally uses:

https://github.com/fabian-hiller/formisch/blob/5c6470a90cdc0c39f26eed42c2eca33eacd35990/packages/core/src/field/setFieldInput/setFieldInput.ts#L65-L72

However, the key is not in null and undefined, so an error will be thrown.

Additional Issue

The input type of nullish field is narrowed from T | null | undefined to T | null

[fabian-hiller]

Thank you for reporting this issue! I will try to take a look at it later or in the next few days.

[fabian-hiller]

I will try to look into this tomorrow evening.

[fabian-hiller]

This will be fixed in the next release. Is this blocking you? Should I release it as soon as possible?

What's your use cases for calling setInput with null or undefined for objects? What data does your object contain? I ask because Formisch does not return null or undefined as the output for this field right now. It would return an object with undefined properties instead.

[Huliiiiii]

Usually, I call setInput with undefined if I want to reset the field to the empty state.

I understand that for objects, Formisch does not return null or undefined.
My use case is to reset all fields (of the object) at once with a single setInput call, rather than resetting them one by one.

[Huliiiiii]

This will be fixed in the next release. Is this blocking you? Should I release it as soon as possible?

Feel free to release it whenever you like — it only impacts one of my fields.

[fabian-hiller]

For resetting your form or individual fields I recommend taking a look at our reset method. But if you just want to set all nested properties to undefined you can also continue calling setInput with undefined. I will release a new version probably today.

[fabian-hiller]

A new version is out

[Huliiiiii]

This is a bit verbose.

if (val) {
  setInput(..., {
    input: val
  })
} else {
  reset(..., {
    initialValue: undefined
  })
}

[fabian-hiller]

Yeah, if reset provides no benefit in your cases feel free to stick to setInput.

[Huliiiiii]

Reopening this issue because the typeScript error is still not fixed.