Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show not exist when disable not-found addon #241

Merged

Conversation

jichenjc
Copy link
Contributor

@jichenjc jichenjc commented Jun 8, 2022

close #240
Signed-off-by: jichenjc jichenjc@cn.ibm.com

@openshift-ci openshift-ci bot requested review from ycyaoxdu and yue9944882 June 8, 2022 08:14
@jichenjc
Copy link
Contributor Author

jichenjc commented Jun 8, 2022

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2022

@jichenjc: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jichenjc
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jun 16, 2022

@jichenjc: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiujian16
Copy link
Member

thank would you try rebase and push again? seems ci has some issue to rerun.

Signed-off-by: jichenjc <jichenjc@cn.ibm.com>
@jichenjc
Copy link
Contributor Author

Thanks for the reminder, pushed again~

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jul 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 796024a into open-cluster-management-io:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should report error during disable when there is no such addon
3 participants