Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sa token issue in 1.24 #252

Merged

Conversation

qiujian16
Copy link
Member

@qiujian16 qiujian16 commented Jul 21, 2022

Signed-off-by: Jian Qiu jqiu@redhat.com

fixes #251

@openshift-ci openshift-ci bot requested review from ycyaoxdu and yue9944882 July 21, 2022 07:57
Copy link
Member

@ycyaoxdu ycyaoxdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: Jian Qiu <jqiu@redhat.com>
Signed-off-by: Jian Qiu <jqiu@redhat.com>
Signed-off-by: Jian Qiu <jqiu@redhat.com>
@qiujian16 qiujian16 force-pushed the fix-sa-token branch 2 times, most recently from 45679c8 to 17a00ff Compare August 22, 2022 02:01
Signed-off-by: Jian Qiu <jqiu@redhat.com>
@qiujian16 qiujian16 force-pushed the fix-sa-token branch 5 times, most recently from 1e29802 to 6732ec5 Compare August 22, 2022 05:11
@qiujian16 qiujian16 force-pushed the fix-sa-token branch 5 times, most recently from 4cea52d to a411756 Compare August 22, 2022 10:07
Signed-off-by: Jian Qiu <jqiu@redhat.com>
Copy link
Member

@ycyaoxdu ycyaoxdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 22, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, ycyaoxdu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f050413 into open-cluster-management-io:main Aug 22, 2022
@qiujian16 qiujian16 deleted the fix-sa-token branch August 22, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: command clusteradm init failed
3 participants