✨ ✨ Feature/auto approval registration #470
Conversation
alex0chan
force-pushed
the
feature/auto-approval-registration
branch
from
77b902b to
192ab0a
Compare
ramekris3163
changed the title
pkg/cmd/init/exec.go
Outdated
| @@ -157,6 +159,32 @@ func (o *Options) validate() error { | |||
| } | |||
| } | |||
|
|
|||
| featureGates := o.clusterManagerChartConfig.ClusterManager.RegistrationConfiguration.FeatureGates | |||
There was a problem hiding this comment.
I think we have a featuregate flag that you can directly identify rather than check the config. You could check genericclioptionsclusteradm.HubMutableFeatureGate directly
pkg/cmd/init/exec.go
Outdated
| } | ||
| } | ||
|
|
||
| if managedClusterAutoApprove { |
There was a problem hiding this comment.
this should be in the Validate func.
There was a problem hiding this comment.
this is part of the Validate Function.
pkg/cmd/init/cmd.go
Outdated
| @@ -81,7 +81,7 @@ func NewCmd(clusteradmFlags *genericclioptionsclusteradm.ClusteradmFlags, stream | |||
| _ = clusterManagerSet.SetAnnotation("singleton-name", "singletonSet", []string{}) | |||
| o.Helm.AddFlags(singletonSet) | |||
| cmd.Flags().AddFlagSet(singletonSet) | |||
| cmd.Flags().StringArrayVar(&o.registrationAuth, "registration-auth", []string{}, | |||
| cmd.Flags().StringSliceVar(&o.registrationAuth, "registration-auth", []string{}, | |||
There was a problem hiding this comment.
registration-drivers since it is plural
ramekris3163
force-pushed
the
feature/auto-approval-registration
branch
from
1a54036 to
35690fc
Compare
jeffw17
force-pushed
the
feature/auto-approval-registration
branch
2 times, most recently
from
2e21916 to
a51da54
Compare
…hitelist for auto approval Signed-off-by: Jeffrey Wong <jeffreywong0417@gmail.com>
jeffw17
force-pushed
the
feature/auto-approval-registration
branch
from
a51da54 to
0727737
Compare
pkg/cmd/init/exec.go
Outdated
| if !validRegistrationDriver.Has(driver) { | ||
| return fmt.Errorf("only csr and awsirsa are valid drivers") | ||
| } | ||
| } | ||
|
|
||
| featureGates := genericclioptionsclusteradm.ConvertToFeatureGateAPI( |
There was a problem hiding this comment.
what I meant here is use
if genericclioptionsclusteradm.HubMutableFeatureGate.Enabled("ManagedClusterAutoApproval"):
.....
…oval Signed-off-by: Jeffrey Wong <jeffreywong0417@gmail.com>
jeffw17
force-pushed
the
feature/auto-approval-registration
branch
from
40e2991 to
438e8cd
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, ramekris3163 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit b50ec8d
into
open-cluster-management-io:main
Summary
Fixes #514