Make OperatorPolicy RelatedObjects optional

Other status fields are not required, and this field was specifically
causing an issue for the new validation condition, since it does not
have any relatedObjects associated with it.

This both fixes the CRD and the behavior of the controller (so that
field is always set) so that if the CRD on the cluster is still the
old one, the controller will not get stuck.

Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>

api/v1beta1/operatorpolicy_types.go

@@ -100,6 +100,7 @@ type OperatorPolicyStatus struct {
 	// +listMapKey=type
 	Conditions []metav1.Condition `json:"conditions,omitempty"`
 	// List of resources processed by the policy
+	// +optional
 	RelatedObjects []policyv1.RelatedObject `json:"relatedObjects"`
 }
 

controllers/operatorpolicy_status.go

@@ -149,6 +149,10 @@ func (r *OperatorPolicyReconciler) updateStatus(
 	}
 
 	if condChanged || relObjsChanged {
+		if policy.Status.RelatedObjects == nil {
+			policy.Status.RelatedObjects = []policyv1.RelatedObject{}
+		}
+
 		return r.Status().Update(ctx, policy)
 	}
 

deploy/crds/kustomize_operatorpolicy/policy.open-cluster-management.io_operatorpolicies.yaml

@@ -219,8 +219,6 @@ spec:
                       type: string
                   type: object
                 type: array
-            required:
-            - relatedObjects
             type: object
         type: object
     served: true

deploy/crds/policy.open-cluster-management.io_operatorpolicies.yaml

@@ -213,8 +213,6 @@ spec:
                       type: string
                   type: object
                 type: array
-            required:
-            - relatedObjects
             type: object
         type: object
     served: true