-
Notifications
You must be signed in to change notification settings - Fork 19
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use patches for adding and removing finalizers
Using update can have unintended consequences such as setting empty values of fields that were nil on the server. This happens for the evaluationInterval field where if it wasn't set, the update adds an empty map, which triggers the spec-sync to remove the nil map. This unnecessary spec-sync update causes the status update to fail later on in the ConfigurationPolicy processing. Additionally, when a finalizer can't be added or removed, the evaluation stops and would be retried on the next run. This is a safer approach. Signed-off-by: mprahl <mprahl@users.noreply.github.com>
- Loading branch information
Showing
2 changed files
with
28 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters