Use the controller ServiceAccount for tests #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaiducek
force-pushed
the
2439-sa-e2e
branch
5 times, most recently
from
e4ac094
to
9f5a469
Compare
|
/hold for reviews |
dhaiducek
force-pushed
the
2439-sa-e2e
branch
2 times, most recently
from
bc70331
to
eff60b6
Compare
JustinKuli
reviewed
Feb 6, 2023
JustinKuli
previously approved these changes
Feb 6, 2023
mprahl
reviewed
Feb 6, 2023
mprahl
reviewed
Feb 6, 2023
dhaiducek
force-pushed
the
2439-sa-e2e
branch
from
eff60b6
to
17c5450
Compare
dhaiducek
force-pushed
the
2439-sa-e2e
branch
from
17c5450
to
a2b3611
Compare
Previously the tests ran the controller binary locally using the default kubeadmin kubeconfig. This generates a new kubeconfig using the controller ServiceAccount for the local binary to use. ref: https://issues.redhat.com/browse/ACM-2439 Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
dhaiducek
force-pushed
the
2439-sa-e2e
branch
from
a2b3611
to
1f9464f
Compare
JustinKuli
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
Assuming @mprahl's suggestions were all resolved, I think it looks fine :D
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the tests ran the controller binary locally using the default kubeadmin kubeconfig. This generates a new kubeconfig using the controller ServiceAccount for the local binary to use.
ref: https://issues.redhat.com/browse/ACM-2439
Signed-off-by: Dale Haiducek 19750917+dhaiducek@users.noreply.github.com