Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add label to designate config policy as template #103

Conversation

willkutler
Copy link
Contributor

Signed-off-by: Will Kutler wkutler@redhat.com

@willkutler willkutler changed the title add label to designate config policy as crd add label to designate config policy as template Feb 7, 2023
@openshift-ci openshift-ci bot added the approved label Feb 7, 2023
@openshift-ci openshift-ci bot removed the approved label Feb 7, 2023
@willkutler
Copy link
Contributor Author

/hold CRD generation is removing the field

Signed-off-by: Will Kutler <wkutler@redhat.com>
@willkutler
Copy link
Contributor Author

/unhold added the label via kustomize to get around kubebuilder removing it. should be good to go now

@willkutler
Copy link
Contributor Author

/unhold

Copy link
Member

@JustinKuli JustinKuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a link to related work for why this is necessary? Just to keep things traceable. And it looks like Prow wants you to rebase it, then I will approve again.

@openshift-ci
Copy link

openshift-ci bot commented Feb 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JustinKuli, willkutler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JustinKuli,willkutler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants