Pull in the new template utils with copy template functions #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gparvin
requested review from
willkutler,
dhaiducek,
ckandag,
mprahl and
yiraeChristineKim
mprahl
reviewed
Mar 30, 2023
test/resources/case13_templatization/case13_copy_referenced_configmap.yaml
Outdated
Show resolved
Hide resolved
mprahl
reviewed
Mar 30, 2023
Adding support for the new go template functions: - copyConfigMapData - copySecretData These copy the data section of ConfigMap or Secret resources so individual keys don't have to be specified Refs: - https://issues.redhat.com/browse/ACM-2611 Signed-off-by: Gus Parvin <gparvin@redhat.com>
mprahl
reviewed
Apr 3, 2023
| Expect(err).To(BeNil()) | ||
| Expect(replConfigMap.Data["message"]).To(Equal("Hello Raleigh!")) | ||
| }) | ||
| It("Cleans up", func() { |
There was a problem hiding this comment.
This should ideally be an AfterAll, but it looks like the rest of the test code in this file does it this way already. For the sake of time, I'll let this slide, but in the future, please use AfterAll.
mprahl
approved these changes
Apr 3, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gparvin, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for the new go template functions:
Refs: