Tweak error handling #117
Merged
Tweak error handling #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dhaiducek
commented
Apr 6, 2023
•
dhaiducek
commented
- Adds a target for foreground logging during E2E
- Removes a pointless return of an input pointer variable
- Adds error handling when the Get for the deletion object fails
dhaiducek
force-pushed
the
status-refetch
branch
3 times, most recently
from
81a39e2
to
10ebf99
Compare
mprahl
reviewed
Apr 6, 2023
|
/hold |
JustinKuli
reviewed
Apr 6, 2023
dhaiducek
force-pushed
the
status-refetch
branch
from
10ebf99
to
6d2b0a0
Compare
Prints controller logs to stdin during E2E test run. Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
Fixes some mishandled/unreturned errors Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
dhaiducek
force-pushed
the
status-refetch
branch
from
6d2b0a0
to
2c3ef85
Compare
|
/unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, gparvin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.