Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type Assertion Paranoia #121

Merged
merged 4 commits into from
Apr 13, 2023
Merged

Type Assertion Paranoia #121

merged 4 commits into from
Apr 13, 2023

Commits on Apr 11, 2023

  1. Refactor to avoid some panics 

    A helper function helps ensure this is handled more consistently, and
more safely.

Refs:
 - https://issues.redhat.com/browse/ACM-4309

Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
    @JustinKuli
    JustinKuli committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    3c0024d View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Add a templateIdentifier type 

    This real type removes the need for type assertions in the
`createInformStatus` function.

Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
    @JustinKuli
    JustinKuli committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    e5bf8df View commit details
    Browse the repository at this point in the history

  2. Add a countedVal internal type 

    This may help performance slightly, and removes the need for some type
assertions in the `mergeArrays` function.

Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
    @JustinKuli
    JustinKuli committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    03dfa92 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. Remove more type assertions 

    Some of these may be bordering on paranoia, and my search was not
totally exhaustive... but this should make me feel a little bit safer.

Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
    @JustinKuli
    JustinKuli committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    f142739 View commit details
    Browse the repository at this point in the history