Optimize handleObjects method #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clyang82
force-pushed
the
optimize_handleObjects
branch
3 times, most recently
from
04636ba
to
2d4db2e
Compare
|
/assign @mprahl |
mprahl
reviewed
May 25, 2023
|
|
||
| unstruct, err := unmarshalFromJSON(objectT.ObjectDefinition.Raw) | ||
| if err != nil { | ||
| os.Exit(1) |
There was a problem hiding this comment.
I know you didn't write this code but could you please change this to a panic instead?
|
Nice optimization @clyang82 . Just a minor comment to address. |
|
This a minor but impactful change--thanks, @clyang82! |
Signed-off-by: clyang82 <chuyang@redhat.com>
clyang82
force-pushed
the
optimize_handleObjects
branch
from
6aabb25
to
0c8f105
Compare
mprahl
approved these changes
Jun 1, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clyang82, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems we do not need to call
getMappingorunmarshalFromJSONfor the ObjectDefinition in a loop of relevantNamespaces. Nothing changes in the loop. So move it in the upper level to reduce the cpu and memory consumption.