Remove fail-fast for Ginkgo
#152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parallel tests cause parallel processes to get interrupted, creating too much noise (and it's unnecessary now that the tests complete in a reasonable time). Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
yiraeChristineKim
previously approved these changes
Jul 7, 2023
Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
- Use `ExpectWithOffset()` for deletion functions - Add debug information to `GetWithTimeout()` Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
|
There was one flake that showed up which I've added some additional logging for if it shows up again, but the fail fast flag removal was also working as expected, so this is ready for review. |
JustinKuli
approved these changes
Jul 10, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallel tests cause parallel processes to get interrupted on a failure, creating too much noise (and it's unnecessary now that the tests complete in a reasonable time).
The
-pflag is also redundant since--procsis already specifying parallelism since its default is 1.