Reduce the copying when evaluating a policy #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the recursive copying to just the value in the object template since that is what is used for merging the existing value in. For safety, the existing object that is used to merge into the template object is copied just once up front. Signed-off-by: mprahl <mprahl@users.noreply.github.com>
mprahl
changed the title
|
@JustinKuli what are your thoughts on this one? I'm aiming to reduce memory consumption and this seemed like a decent candidate. |
yiraeChristineKim
approved these changes
Aug 8, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mprahl, yiraeChristineKim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit d877c5e
into
open-cluster-management-io:main
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the recursive copying to just the value in the object
template since that is what is used for merging the existing value in.
For safety, the existing object that is used to merge into the template
object is copied just once up front.