NamespaceSelector updates triggering evaluations #157
Conversation
This also tries to use channels to communicate, as opposed to a map that would need a mutex... I don't know if it's really better, it feels out of place. The downsides to this approach are noted in the last 2 new tests.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
As of now, I prefer the other approach. |
|
Closed in favor of #158 |
This approach uses the new feature in github.com/stolostron/kubernetes-dependency-watches, but it comes with some downsides (compare to #158):
This implementation also uses a channel for communication as opposed to a shared map that would likely require a mutex, but I don't know if this approach is actually better.