ACM-6596: Initialize controller for OperatorPolicy #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JeffeyL The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Consistently log the policy noncompliance and compliance as updates are made. The goal is to allow tools that scrape logs to be able to obtain the violation message and the details on when compliance changes happen. Refs: - https://issues.redhat.com/browse/ACM-5568 Signed-off-by: Gus Parvin <gparvin@redhat.com>
Previously, these settings were not being applied to the config used in 'hosted mode'. This commit also includes a typo fix, and adjusts some settings used by the tests. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
Previously, the evaluation interval could prevent policies from being applied on new namespaces when they appeared. Now, a new controller watches namespaces on the target cluster, and can signal to the config policy controller when a policy's selected namespaces have changed, so that it can be re-evaluated. A new controller-manager is used in hosted mode, in order to create a cache for the namespaces on the target cluster. This change required some setup adjustments in order to start both managers in this case. Refs: - https://issues.redhat.com/browse/ACM-6428 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
https://issues.redhat.com/browse/ACM-6595 Signed-off-by: Jason Zhang <jaszhang@redhat.com>
ref: https://issues.redhat.com/browse/ACM-6596 Signed-off-by: Jeffrey Luo <jeluo@redhat.com>
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main.gofor inclusion of the operatorPolicy controller under the same manager as the configurationPolicy controllercontrollers/operatorpolicy_controller.go) for logging operator policies on the cluster, as well as updating their compliance (currently no actual logic behind this)Ref: https://issues.redhat.com/browse/ACM-6596