Add an error when apiVersion is missing #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
dco-signoff: yes
approved
dco-signoff: no
and removed
dco-signoff: yes
labels
JustinKuli
force-pushed
the
7127-missing-apiversion
branch
2 times, most recently
from
53c5ed7
to
87bf0c8
Compare
JustinKuli
force-pushed
the
7127-missing-apiversion
branch
2 times, most recently
from
3e02a50
to
819021e
Compare
The apiVersion field is generally required by kubernetes objects... it's surprising that this situation wasn't already caught by an error when decoding or getting a mapping. Refs: - https://issues.redhat.com/browse/ACM-7127 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
This test has been flakey - the last check for Compliant events has been coming back empty unexpectedly. This will print information about all of the events to help understand what is happening. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
JustinKuli
force-pushed
the
7127-missing-apiversion
branch
from
819021e
to
b24c4dd
Compare
|
Now that I added useful debugging for the flakey test, it's passed 4 times in a row 😿 |
gparvin
approved these changes
Sep 20, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gparvin, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit 62a3ac4
into
open-cluster-management-io:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The apiVersion field is generally required by kubernetes objects... it's surprising that this situation wasn't already caught by an error when decoding or getting a mapping.
Refs: